1574850 - 3.5% tp5n main_startup_fileio (windows7-32-shippable) regression on push c2141e08383873f70201cc84613ef5904cb27d07 (Fri August 9 2019)

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=c2141e08383873f70201cc84613ef5904cb27d07

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

4% tp5n main_startup_fileio windows7-32-shippable opt e10s stylo 104,998,442.83 -> 108,668,391.67
3% tp5n main_startup_fileio windows7-32-shippable opt e10s stylo 104,955,928.33 -> 108,603,456.50

Improvements:

2% tp5o_webext windows10-64-shippable opt e10s stylo 161.06 -> 157.37
2% tp5o_webext windows7-32-shippable opt e10s stylo 156.65 -> 153.33
2% tp5o_webext windows10-64-shippable-qr opt e10s stylo 157.03 -> 153.81

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=22578

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/TestEngineering/Performance/Talos

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/TestEngineering/Performance/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/TestEngineering/Performance/Talos/RegressionBugsHandling

Comment 1

[Nathan Froyd [:froydnj]]

The linked push in comment 0 doesn't even have a change written by me in it. And the patch in the linked push doesn't look like it would cause regressions in fileio.

Are you sure you have the right push?

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

I'm sorry, Nathan, I misspelled the details. Now they are accurate.

Comment 3

[Nathan Froyd [:froydnj]]

We are accepting this as part of the cross-language LTO enablement.