1574873 - The Mobile Promotion is wrongly displayed on “about:logins” page when you are not signed in to Sync

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: MobilePromotion_wronglyDisplayed.PNG

[Notes]:

• Based on the mock-ups, the Mobile Promo should be displayed only for users signed in to sync

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-18) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• The Firefox browser is opened.
• You are not signed in to Sync.

[Steps to reproduce]:

1. Navigate to “about:logins” page
2. Observe the footer of the page.

[Expected result]:

• The Mobile promotion is not displayed.

[Actual result]:

• The Mobile Promotion is displayed.

[Additional notes]:

• Attached a screenshot with the issue.

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1574873 - The Mobile Promotion is wrongly displayed on “about:logins” page when you are not signed in to Sync r?MattN

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1574873 - The Mobile Promotion is wrongly displayed on “about:logins” page when you are not signed in to Sync r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3d5f2f611fc
The Mobile Promotion is wrongly displayed on “about:logins” page when you are not signed in to Sync r=MattN

Comment 4

[Phabricator Automation]

Comment on attachment 9087192 [details]
Bug 1574873 - The Mobile Promotion is wrongly displayed on “about:logins” page when you are not signed in to Sync r?MattN

Revision D42948 was moved to bug 1574869. Setting attachment 9087192 [details] to obsolete.

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c3d5f2f611fc

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

c3d5f2f611fc was for bug 1574869.

Comment 7

[Maxx Crawford [:maxx]]

From :rgaddis: https://bugzilla.mozilla.org/show_bug.cgi?id=1574878#c2

I don't think the promo should be shown in the following instances:

No logins
Create login
Edit login

Comment 9

[Maxx Crawford [:maxx]]

Attachment: Bug 1574873 - The Mobile Promotion is wrongly displayed on “about:logins” page when you are not signed in to Sync r?MattN

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b04d121c56c
The Mobile Promotion is wrongly displayed on “about:logins” page when you are not signed in to Sync r=MattN

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0b04d121c56c

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-26) (64-bit) on Windows 7, MacOS 10.14 and Ubuntu 16.04.

• The Mobile Promo is not displayed if you are not signed in to Sync.