1574878 - The Mobile Promotion is not centered on the “about:logins” page

Status: RESOLVED DUPLICATE of bug 1574873

(Firefox :: about:logins, defect)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: MobilePromotion_NotCentered.PNG

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-18) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• The Firefox browser is opened.
• You are signed with a valid FxA.

[Steps to reproduce]:

1. Navigate to “about:logins” page.
2. Observe the position of the Mobile Promotion from the footer of the page.

[Expected result]:

• The Mobile Promotion is centered.

[Actual result]:

• The Mobile Promotion is not centered.

[Notes]:

• Attached a screenshot with the issue.

Comment 1

[Matthew N. [:MattN]]

Ryan, do you think we should not show the promo in the no logins view? It doesn't make sense to offer to take no logins to other devices. It seems like we should move it to be a child of the <login-item> (right pane).

Comment 2

[rgaddis]

I don't think the promo should be shown in the following instances:

• No logins
• Create login
• Edit login

Comment 3

[Matthew N. [:MattN]]

Thanks we will handle hiding on those modes in bug 1574873.