1574940 - The “x” button from the Mobile Promotion cannot be focus when navigating with the “Tab” key

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: MobilePromotion_navigation.mp4

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-18) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• The Firefox browser is opened.
• You are signed with a valid FxA.
• Have at least one saved login.

[Steps to reproduce]:

1. Navigate to “about:logins” page.
2. Press the "Tab" key until the "GET IT ON Google Play" button is focused.
3. Press the “Tab” key and observe the behavior.

[Expected result]:

• The “X’ button of the Mobile Promotion is focused.

[Actual result]:

• The “Logins & Passwords” tab is focused.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[Matthew N. [:MattN]]

This should be a <button>.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1574940 - The close button in the mobile footer of about:logins should be clickable via 'Enter'. r?MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42f98e7648bd
The close button in the mobile footer of about:logins should be clickable via 'Enter'. r=MattN

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/42f98e7648bd

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-23)(64-bit) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

• The “x” button from the Mobile Promotion can be focus using the “Tab” key. Also, if the "Enter" key is pressed while the "X" button is focused, the Mobile Promo is correctly dismissed.