1574948 - Redirects don't preserve the `firefox-source-docs` host name

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Documentation, defect)

Description

[Andrew Halberstadt [:ahal]]

Bug 1527363 implements the ability to specify redirects, but the hostname isn't preserved. E.g:
https://firefox-source-docs.mozilla.org/testing/marionette/marionette/index.html

Redirects to:
http://gecko-docs.mozilla.org.s3-website-us-west-2.amazonaws.com/testing/marionette/index.html

This is the same document so it's correct. But:

1. The change in host is surprising / confusing
2. The AWS endpoint doesn't have SSL enabled

Comment 1

[Andrew Halberstadt [:ahal]]

Glancing at:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html?highlight=upload_fileobj#S3.Client.put_bucket_website

We might need to set RoutingRules.Redirect.HostName to firefox-source-docs.mozilla.org. It's going to be hard to test this on try (as we don't have any domains pointing at it). We might need to just land and see.

Comment 2

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1574948 - Preserve the `firefox-source-docs` host name. r=ahal

Comment 3

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1574948 - Call delete after upload to avoid Contents key error. r=ahal

Depends on D42548

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebd3f5f81b02
Preserve the `firefox-source-docs` host name. r=ahal
https://hg.mozilla.org/integration/autoland/rev/199cb0cffeca
Call delete after upload to avoid Contents key error. r=ahal

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/ebd3f5f81b02
https://hg.mozilla.org/mozilla-central/rev/199cb0cffeca