1574949 - The buttons from the Mobile Promotion does not work using the "Enter" key

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Mobile Promotion Enter key.gif

[Affected Versions]:

• Nightly 70.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a Firefox profile with multiple saved logins.
• You are signed with a valid FxA.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Press the "Tab" key until the "Download on the App Store" button is focused.
4. Press the "Enter" key and observe the behavior.

[Expected results]:

• The Apple Store page with the Firefox Lockwise app is opened in a new tab.

[Actual results]:

• Nothing happens.

[Notes]:

• The issue is also reproducible of the "GET IT ON Google Play" button.
• Attached a screen recording with the issue.

Comment 1

[Matthew N. [:MattN]]

Thanks. The problem is that the code is using originalTarget instead of target for its checks related to these buttons. Also, is there a reason these aren't using <a href=""> (still using the event to do the actual work)? It seems like it would be semantically better.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1574949 - Use event.currentTarget to get the reference to the button when acting on the click event so it will work regardless of what inner content is clicked or if the button itself is clicked. r?MattN

I didn't switch to using an A element with href= since the link target depends on the value of a preference, which is set at runtime in browser_dismissFooter.js and would necessitate refactoring of the test.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14abb9b889f4
Use event.currentTarget to get the reference to the button when acting on the click event so it will work regardless of what inner content is clicked or if the button itself is clicked. r=MattN

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/14abb9b889f4

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-23)(64-bit) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

• The "Download on the App Store" and the "GET IT ON Google Play" buttons from the Mobile Promotion can be accessed using the "Enter" key.