1574995 - Update Firefox workmark for the New Tab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Stephen Horlander [:shorlander]]

Update the Firefox wordmark you see when the only visible section on New Tab is Web Search. Also visible on Private Browsing pages.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5264

Comment 2

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/ea3eebc73ccb

Comment 3

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue on Latest Firefox Nightly 70.0.a1 (ID Build: 20190825213650) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The Firefox icon and wordmark sizes are correctly updated to 96px, respectively 172px on the "about:newtab" and "about:home" pages.

However, the icon and wordmark sizes remained unchanged on the "about:privatebrowsing", the icon size is 97px and the wordmark is 175px.
@Stephen Was it intended to also update them on the "about:privatebrowsing" page?

Comment 4

[Stephen Horlander [:shorlander]]

(In reply to Andreea Cupsa [:acupsa], Experiments QA from comment #3)

I have verified this issue on Latest Firefox Nightly 70.0.a1 (ID Build: 20190825213650) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The Firefox icon and wordmark sizes are correctly updated to 96px, respectively 172px on the "about:newtab" and "about:home" pages.

However, the icon and wordmark sizes remained unchanged on the "about:privatebrowsing", the icon size is 97px and the wordmark is 175px.
@Stephen Was it intended to also update them on the "about:privatebrowsing" page?

Yes, they should be the same. I didn't realize the Private Browsing page was using different variables.

Comment 5

[Ed Lee :Mardak]

Attachment: Bug 1574995 - Update Firefox workmark for the Private Browsing page

Adjust sizing to match https://github.com/mozilla/activity-stream/commit/ba740fb695efbe0c5b7817ffc2439293aff34b39

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee9ff899ce0c
Update Firefox workmark for the Private Browsing page r=k88hudson

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ee9ff899ce0c

Comment 8

[Andreea Cupsa [:acupsa], Experiments QA]

The Firefox icon and wordmark sizes are now correctly updated to 96px, respectively 172px on the "about:newtab", "about:home" and the "about:privatebrowsing" pages.
I have verified the issue on Latest Firefox Nightly 70.0a1 (Build ID: 20190901214807) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee9ff899ce0c