Closed Bug 1574995 Opened 3 months ago Closed 3 months ago

Update Firefox workmark for the New Tab page

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox70 --- verified

People

(Reporter: shorlander, Assigned: shorlander)

References

(Blocks 1 open bug)

Details

(Keywords: github-merged)

Attachments

(2 files)

Update the Firefox wordmark you see when the only visible section on New Tab is Web Search. Also visible on Private Browsing pages.

Blocks: 1575658
Blocks: 1576284
Status: NEW → RESOLVED
Iteration: --- → 70.4 - Aug 19 - Sep 1
Closed: 3 months ago
Keywords: github-merged
Priority: -- → P1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

I have verified this issue on Latest Firefox Nightly 70.0.a1 (ID Build: 20190825213650) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The Firefox icon and wordmark sizes are correctly updated to 96px, respectively 172px on the "about:newtab" and "about:home" pages.

However, the icon and wordmark sizes remained unchanged on the "about:privatebrowsing", the icon size is 97px and the wordmark is 175px.
@Stephen Was it intended to also update them on the "about:privatebrowsing" page?

Flags: needinfo?(shorlander)

(In reply to Andreea Cupsa [:acupsa], Experiments QA from comment #3)

I have verified this issue on Latest Firefox Nightly 70.0.a1 (ID Build: 20190825213650) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The Firefox icon and wordmark sizes are correctly updated to 96px, respectively 172px on the "about:newtab" and "about:home" pages.

However, the icon and wordmark sizes remained unchanged on the "about:privatebrowsing", the icon size is 97px and the wordmark is 175px.
@Stephen Was it intended to also update them on the "about:privatebrowsing" page?

Yes, they should be the same. I didn't realize the Private Browsing page was using different variables.

Flags: needinfo?(shorlander)
Pushed by elee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee9ff899ce0c
Update Firefox workmark for the Private Browsing page r=k88hudson

The Firefox icon and wordmark sizes are now correctly updated to 96px, respectively 172px on the "about:newtab", "about:home" and the "about:privatebrowsing" pages.
I have verified the issue on Latest Firefox Nightly 70.0a1 (Build ID: 20190901214807) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.