Closed
Bug 1575036
Opened 5 years ago
Closed 5 years ago
Failing Mochitests (bct) - browser_ext_browserAction.js
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 70.0
People
(Reporter: jorgk-bmo, Assigned: darktrojan)
Details
Attachments
(1 file)
|
4.61 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/browser/browser_ext_browserAction.js | Default icon - Got none, expected url("chrome://messenger/content/extension.svg")
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/browser/browser_ext_browserAction.js | Correct label - Got , expected This is a test
These failures confuse everyone.
Flags: needinfo?(geoff)
|
Assignee | |
Comment 1•5 years ago
|
||
With these changes the test suite was green 25 times on Try. I don't know if that means it's actually working every time, but it seems like an improvement.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attachment #9086583 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9086583 [details] [diff] [review] 1575036-mochitest-timeouts-1.diff Review of attachment 9086583 [details] [diff] [review]: ----------------------------------------------------------------- Quite of a hack... I wish there would be something real to await on. But I guess it doesn't really hurt either.
Attachment #9086583 -
Flags: review?(mkmelin+mozilla) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fc6df7c5e3da
Try again to fix browser_ext_browserAction.js/browser_ext_composeAction.js. r=mkmelin DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
|
Reporter | |
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 70.0
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•