Closed Bug 1575055 Opened 5 years ago Closed 5 years ago

Small cleanups in CompileOptions code

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla71

Tracking Flags:

Tracking

Status

firefox71

---

fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

(Blocks 1 open bug)

Details

Attachments

(5 files, 4 obsolete files)

Bug 1575055 - Cleanup CompileOptions::setIntroductionInfo. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Privatize js::CompileOptions::strictMode. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Remove redundant overrides in ReadOnlyCompileOptions. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Avoid duplicating CompileOptions constructor code. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Reorganize js::ScriptSource. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Use field initializers for js::ScriptSource. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Use Maybe for ScriptSource::introductionOffset. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1575055 - Remove unused CompileOptions::setIntroductionScript. r?jandem 5 years ago Ted Campbell [:tcampbell] 47 bytes, text/x-phabricator-request		Details \| Review

Ted Campbell [:tcampbell]

Assignee

Description

•

5 years ago

Various cleanups in JS::CompileOptions. Patches incoming..

Ted Campbell [:tcampbell]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1575055 - Cleanup CompileOptions::setIntroductionInfo. r?jandem (obsolete) — Details

The hasIntroductionInfo flag is equivalent to checking for the existance
introducerFilename so use that instead. Also remove unused setter for
the introducer script.

Ted Campbell [:tcampbell]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1575055 - Privatize js::CompileOptions::strictMode. r?jandem — Details

We already have an accessor to make sure this is can only be set but not
cleared so hide the underlying storage.

Depends on D42558

Ted Campbell [:tcampbell]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1575055 - Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r?jandem — Details

These must be combined to read so instead take the same approach as
strict-mode where we have a maybe* accessor to update it that may be
overriden. If anything requests full-parsing we will do it.

Depends on D42559

Ted Campbell [:tcampbell]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1575055 - Remove redundant overrides in ReadOnlyCompileOptions. r?jandem — Details

Depends on D42560

Ted Campbell [:tcampbell]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1575055 - Avoid duplicating CompileOptions constructor code. r?jandem — Details

Depends on D42561

Ted Campbell [:tcampbell]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1575055 - Reorganize js::ScriptSource. r?jandem (obsolete) — Details

Group fields together within class defintion and add a few more
comments.

Ted Campbell [:tcampbell]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1575055 - Use field initializers for js::ScriptSource. r?jandem (obsolete) — Details

Also reorder the fields for better organization.

Depends on D42684

Ted Campbell [:tcampbell]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1575055 - Use Maybe for ScriptSource::introductionOffset. r?jandem (obsolete) — Details

Depends on D42685

Phabricator Automation

Comment 9

•

5 years ago

Comment on attachment 9086746 [details]
Bug 1575055 - Reorganize js::ScriptSource. r?jandem

Revision D42684 was moved to bug 1575298. Setting attachment 9086746 [details] to obsolete.

Attachment #9086746 - Attachment is obsolete: true

Phabricator Automation

Comment 10

•

5 years ago

Comment on attachment 9086747 [details]
Bug 1575055 - Use field initializers for js::ScriptSource. r?jandem

Revision D42685 was moved to bug 1575298. Setting attachment 9086747 [details] to obsolete.

Attachment #9086747 - Attachment is obsolete: true

Phabricator Automation

Comment 11

•

5 years ago

Comment on attachment 9086748 [details]
Bug 1575055 - Use Maybe for ScriptSource::introductionOffset. r?jandem

Revision D42686 was moved to bug 1575298. Setting attachment 9086748 [details] to obsolete.

Attachment #9086748 - Attachment is obsolete: true

Pulsebot

Comment 12

•

5 years ago

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45f0e989e56e
Cleanup CompileOptions::setIntroductionInfo. r=jandem
https://hg.mozilla.org/integration/autoland/rev/51f0929a5c8d
Privatize js::CompileOptions::strictMode. r=jandem
https://hg.mozilla.org/integration/autoland/rev/3ee4fd0e20e0
Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r=jandem
https://hg.mozilla.org/integration/autoland/rev/f770e1398276
Remove redundant overrides in ReadOnlyCompileOptions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/e29819477913
Avoid duplicating CompileOptions constructor code. r=jandem

Noemi Erli[:noemi_erli]

Comment 13

•

5 years ago

Backed out 5 changesets (Bug 1575055) for causing build bustages in mozJSComponentLoader.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=262908803&resultStatus=testfailed%2Cbusted%2Cexception&revision=e29819477913ecb57908cbe35af267000bb0a509

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262908803&repo=autoland&lineNumber=28879

Backout: https://hg.mozilla.org/integration/autoland/rev/e8359e1f941ee7256c0f5c815d4711466fb5bbdf

Flags: needinfo?(tcampbell)

Pulsebot

Comment 14

•

5 years ago

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/400ea400fba2
Cleanup CompileOptions::setIntroductionInfo. r=jandem
https://hg.mozilla.org/integration/autoland/rev/aa9f3f8f1f2c
Privatize js::CompileOptions::strictMode. r=jandem
https://hg.mozilla.org/integration/autoland/rev/aa3a237d49d8
Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r=jandem
https://hg.mozilla.org/integration/autoland/rev/6039cf3a63f0
Remove redundant overrides in ReadOnlyCompileOptions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/6ba35efeddf6
Avoid duplicating CompileOptions constructor code. r=jandem

Cosmin Sabou [:CosminS]

Comment 15

•

5 years ago

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=262926637&resultStatus=testfailed%2Cbusted%2Cexception&revision=6ba35efeddf6851cea089763577596bf54fde7ee&searchStr=xpc

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=262926637&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/bf99d92d78057971af4c3db8b24c482ccb0654d5

[task 2019-08-22T14:04:49.082Z] 14:04:49 [task 2019-08-22T14:04:49.239Z] 14:04:49 [task 2019-08-22T14:04:49.239Z] 14:04:49 [task 2019-08-22T14:04:49.240Z] 14:04:49 [task 2019-08-22T14:04:49.241Z] 14:04:49 [task 2019-08-22T14:04:49.241Z] 14:04:49 [task 2019-08-22T14:04:49.242Z] 14:04:49 [task 2019-08-22T14:04:49.242Z] 14:04:49 [task 2019-08-22T14:04:49.243Z] 14:04:49 [task 2019-08-22T14:04:49.244Z] 14:04:49 [task 2019-08-22T14:04:49.244Z] 14:04:49 [task 2019-08-22T14:04:49.245Z] 14:04:49 [task 2019-08-22T14:04:49.246Z] 14:04:49 [task 2019-08-22T14:04:49.246Z] 14:04:49 [task 2019-08-22T14:04:54.706Z] 14:04:54 [task 2019-08-22T14:04:54.707Z] 14:04:54 [task 2019-08-22T14:04:54.707Z] 14:04:54 [task 2019-08-22T14:04:54.707Z] 14:04:54 [task 2019-08-22T14:04:54.708Z] 14:04:54 [task 2019-08-22T14:04:54.708Z] 14:04:54 [task 2019-08-22T14:04:54.708Z] 14:04:54 [task 2019-08-22T14:04:54.708Z] 14:04:54 [task 2019-08-22T14:04:54.708Z] 14:04:54 [task 2019-08-22T14:04:54.709Z] 14:04:54 [task 2019-08-22T14:04:54.718Z] 14:04:54 [task 2019-08-22T14:04:54.718Z] 14:04:54 [task 2019-08-22T14:04:54.718Z] 14:04:54 [task 2019-08-22T14:04:54.718Z] 14:04:54 [task 2019-08-22T14:04:54.718Z] 14:04:54 [task 2019-08-22T14:04:54.719Z] 14:04:54 [task 2019-08-22T14:04:54.719Z] 14:04:54 [task 2019-08-22T14:04:54.719Z] 14:04:54 [task 2019-08-22T14:04:54.719Z] 14:04:54 [task 2019-08-22T14:04:54.720Z] 14:04:54 [task 2019-08-22T14:04:54.720Z] 14:04:54 [task 2019-08-22T14:04:54.720Z] 14:04:54 [task 2019-08-22T14:04:54.720Z] 14:04:54 [task 2019-08-22T14:04:54.721Z] 14:04:54 [task 2019-08-22T14:04:54.721Z] 14:04:54 [task 2019-08-22T14:04:54.721Z] 14:04:54 [task 2019-08-22T14:04:54.721Z] 14:04:54 [task 2019-08-22T14:04:54.722Z] 14:04:54 [task 2019-08-22T14:04:54.722Z] 14:04:54 [task 2019-08-22T14:04:54.722Z] 14:04:54 [task 2019-08-22T14:04:54.722Z] 14:04:54 [task 2019-08-22T14:04:54.723Z] 14:04:54 [task 2019-08-22T14:04:54.723Z] 14:04:54 [task 2019-08-22T14:04:54.723Z] 14:04:54 [task 2019-08-22T14:04:54.723Z] 14:04:54 [task 2019-08-22T14:04:54.723Z] 14:04:54 [task 2019-08-22T14:04:54.724Z] 14:04:54 [task 2019-08-22T14:04:54.724Z] 14:04:54 [task 2019-08-22T14:04:54.724Z] 14:04:54 [task 2019-08-22T14:04:54.724Z] 14:04:54 [task 2019-08-22T14:04:54.724Z] 14:04:54 [task 2019-08-22T14:04:54.725Z] 14:04:54 [task 2019-08-22T14:04:54.725Z] 14:04:54 [task 2019-08-22T14:04:54.725Z] 14:04:54 [task 2019-08-22T14:04:54.725Z] 14:04:54 [task 2019-08-22T14:04:54.725Z] 14:04:54 [task 2019-08-22T14:04:54.726Z] 14:04:54 [task 2019-08-22T14:04:54.726Z] 14:04:54 [task 2019-08-22T14:04:54.726Z] 14:04:54 [task 2019-08-22T14:04:54.726Z] 14:04:54 [task 2019-08-22T14:04:54.726Z] 14:04:54 [task 2019-08-22T14:04:54.727Z] 14:04:54 [task 2019-08-22T14:04:54.727Z] 14:04:54 [task 2019-08-22T14:04:54.727Z] 14:04:54 [task 2019-08-22T14:04:54.727Z] 14:04:54 [task 2019-08-22T14:04:54.727Z] 14:04:54 [task 2019-08-22T14:04:54.728Z] 14:04:54 [task 2019-08-22T14:04:54.728Z] 14:04:54 [task 2019-08-22T14:04:54.728Z] 14:04:54 [task 2019-08-22T14:04:54.728Z] 14:04:54 [task 2019-08-22T14:04:54.728Z] 14:04:54 [task 2019-08-22T14:04:54.728Z] 14:04:54 [task 2019-08-22T14:04:54.729Z] 14:04:54 [task 2019-08-22T14:04:54.729Z] 14:04:54 [task 2019-08-22T14:04:54.729Z] 14:04:54 [task 2019-08-22T14:04:54.729Z] 14:04:54 [task 2019-08-22T14:04:54.729Z] 14:04:54 [task 2019-08-22T14:04:54.729Z] 14:04:54 [task 2019-08-22T14:04:54.730Z] 14:04:54 [task 2019-08-22T14:04:54.730Z] 14:04:54 [task 2019-08-22T14:04:54.730Z] 14:04:54 [task 2019-08-22T14:04:54.730Z] 14:04:54 [task 2019-08-22T14:04:54.730Z] 14:04:54 [task 2019-08-22T14:04:54.730Z] 14:04:54 [task 2019-08-22T14:04:54.731Z] 14:04:54 [task 2019-08-22T14:04:54.731Z] 14:04:54 [task 2019-08-22T14:04:54.731Z] 14:04:54 [task 2019-08-22T14:04:54.731Z] 14:04:54 [task 2019-08-22T14:04:54.731Z] 14:04:54 [task 2019-08-22T14:04:54.732Z] 14:04:54 [task 2019-08-22T14:04:54.732Z] 14:04:54 [task 2019-08-22T14:04:54.732Z] 14:04:54 [task 2019-08-22T14:04:54.732Z] 14:04:54 [task 2019-08-22T14:04:54.732Z] 14:04:54 [task 2019-08-22T14:04:54.732Z] 14:04:54 [task 2019-08-22T14:04:54.733Z] 14:04:54 [task 2019-08-22T14:04:54.733Z] 14:04:54 [task 2019-08-22T14:04:54.733Z] 14:04:54 [task 2019-08-22T14:04:54.733Z] 14:04:54 [task 2019-08-22T14:04:54.733Z] 14:04:54 [task 2019-08-22T14:04:54.734Z] 14:04:54 [task 2019-08-22T14:04:54.734Z] 14:04:54 [task 2019-08-22T14:04:54.734Z] 14:04:54 [task 2019-08-22T14:04:54.734Z] 14:04:54 [task 2019-08-22T14:04:54.734Z] 14:04:54 [task 2019-08-22T14:04:54.735Z] 14:04:54 [task 2019-08-22T14:04:54.735Z] 14:04:54 [task 2019-08-22T14:04:54.735Z] 14:04:54 [task 2019-08-22T14:04:54.735Z] 14:04:54 [task 2019-08-22T14:04:54.735Z] 14:04:54 [task 2019-08-22T14:04:54.736Z] 14:04:54 [task 2019-08-22T14:04:54.736Z] 14:04:54 [task 2019-08-22T14:04:54.736Z] 14:04:54 [task 2019-08-22T14:04:54.736Z] 14:04:54 [task 2019-08-22T14:04:54.736Z] 14:04:54 [task 2019-08-22T14:04:54.736Z] 14:04:54 [task 2019-08-22T14:04:54.737Z] 14:04:54 [task 2019-08-22T14:04:54.737Z] 14:04:54 [task 2019-08-22T14:04:54.737Z] 14:04:54 [task 2019-08-22T14:04:54.737Z] 14:04:54 [task 2019-08-22T14:04:54.737Z] 14:04:54 [task 2019-08-22T14:04:54.738Z] 14:04:54 [task 2019-08-22T14:04:54.738Z] 14:04:54 [task 2019-08-22T14:04:54.738Z] 14:04:54 [task 2019-08-22T14:04:54.738Z] 14:04:54 [task 2019-08-22T14:04:54.738Z] 14:04:54 [task 2019-08-22T14:04:54.739Z] 14:04:54 [task 2019-08-22T14:04:54.739Z] 14:04:54 [task 2019-08-22T14:04:54.739Z] 14:04:54 [task 2019-08-22T14:04:54.739Z] 14:04:54 [task 2019-08-22T14:04:54.739Z] 14:04:54 [task 2019-08-22T14:04:54.740Z] 14:04:54 [task 2019-08-22T14:04:54.740Z] 14:04:54 [task 2019-08-22T14:04:54.740Z] 14:04:54 [task 2019-08-22T14:04:54.740Z] 14:04:54 [task 2019-08-22T14:04:54.740Z] 14:04:54 [task 2019-08-22T14:04:54.741Z] 14:04:54 [task 2019-08-22T14:04:54.741Z] 14:04:54 [task 2019-08-22T14:04:54.741Z] 14:04:54 [task 2019-08-22T14:04:54.741Z] 14:04:54 [task 2019-08-22T14:04:54.741Z] 14:04:54 [task 2019-08-22T14:04:54.742Z] 14:04:54 [task 2019-08-22T14:04:54.742Z] 14:04:54 [task 2019-08-22T14:04:54.742Z] 14:04:54 [task 2019-08-22T14:04:54.742Z] 14:04:54 [task 2019-08-22T14:04:54.742Z] 14:04:54 [task 2019-08-22T14:04:54.742Z] 14:04:54 [task 2019-08-22T14:04:54.743Z] 14:04:54 [task 2019-08-22T14:04:54.743Z] 14:04:54 [task 2019-08-22T14:04:54.743Z] 14:04:54 [task 2019-08-22T14:04:54.743Z] 14:04:54 [task 2019-08-22T14:04:54.743Z] 14:04:54 [task 2019-08-22T14:04:54.744Z] 14:04:54 [task 2019-08-22T14:04:54.744Z] 14:04:54 [task 2019-08-22T14:04:54.744Z] 14:04:54 [task 2019-08-22T14:04:54.744Z] 14:04:54 [task 2019-08-22T14:04:54.744Z] 14:04:54 [task 2019-08-22T14:04:54.744Z] 14:04:54 [task 2019-08-22T14:04:54.745Z] 14:04:54 [task 2019-08-22T14:04:54.745Z] 14:04:54 [task 2019-08-22T14:04:54.745Z] 14:04:54 [task 2019-08-22T14:04:54.745Z] 14:04:54 [task 2019-08-22T14:04:54.745Z] 14:04:54 [task 2019-08-22T14:04:54.746Z] 14:04:54 [task 2019-08-22T14:04:54.746Z] 14:04:54 [task 2019-08-22T14:04:54.746Z] 14:04:54 [task 2019-08-22T14:04:54.746Z] 14:04:54 [task 2019-08-22T14:04:54.747Z] 14:04:54 [task 2019-08-22T14:04:54.747Z] 14:04:54 [task 2019-08-22T14:04:54.747Z] 14:04:54 [task 2019-08-22T14:04:54.748Z] 14:04:54 [task 2019-08-22T14:04:54.748Z] 14:04:54 [task 2019-08-22T14:04:54.748Z] 14:04:54 [task 2019-08-22T14:04:54.748Z] 14:04:54 [task 2019-08-22T14:04:54.749Z] 14:04:54 [task 2019-08-22T14:04:54.749Z] 14:04:54 [task 2019-08-22T14:04:54.749Z] 14:04:54 [task 2019-08-22T14:04:54.750Z] 14:04:54 [task 2019-08-22T14:04:54.750Z] 14:04:54 [task 2019-08-22T14:04:54.750Z] 14:04:54 [task 2019-08-22T14:04:54.750Z] 14:04:54 [task 2019-08-22T14:04:54.751Z] 14:04:54 [task 2019-08-22T14:04:54.751Z] 14:04:54 [task 2019-08-22T14:04:54.751Z] 14:04:54 [task 2019-08-22T14:04:54.752Z] 14:04:54 [task 2019-08-22T14:04:54.752Z] 14:04:54 [task 2019-08-22T14:04:54.752Z] 14:04:54 [task 2019-08-22T14:04:54.752Z] 14:04:54 [task 2019-08-22T14:04:54.753Z] 14:04:54 [task 2019-08-22T14:04:54.753Z] 14:04:54 [task 2019-08-22T14:04:54.753Z] 14:04:54 [task 2019-08-22T14:04:54.753Z] 14:04:54 [task 2019-08-22T14:04:54.754Z] 14:04:54 [task 2019-08-22T14:04:54.754Z] 14:04:54 [task 2019-08-22T14:04:54.754Z] 14:04:54 [task 2019-08-22T14:04:54.755Z] 14:04:54 [task 2019-08-22T14:04:54.755Z] 14:04:54 [task 2019-08-22T14:04:54.755Z] 14:04:54 [task 2019-08-22T14:04:54.755Z] 14:04:54 [task 2019-08-22T14:04:54.756Z] 14:04:54 [task 2019-08-22T14:04:54.756Z] 14:04:54 [task 2019-08-22T14:04:54.756Z] 14:04:54 [task 2019-08-22T14:04:54.756Z] 14:04:54 [task 2019-08-22T14:04:54.757Z] 14:04:54 [task 2019-08-22T14:04:54.757Z] 14:04:54 [task 2019-08-22T14:04:54.757Z] 14:04:54 [task 2019-08-22T14:04:54.757Z] 14:04:54 [task 2019-08-22T14:04:54.758Z] 14:04:54 [task 2019-08-22T14:04:54.758Z] 14:04:54 [task 2019-08-22T14:04:54.758Z] 14:04:54 [task 2019-08-22T14:04:54.758Z] 14:04:54 [task 2019-08-22T14:04:54.759Z] 14:04:54 [task 2019-08-22T14:04:54.759Z] 14:04:54 [task 2019-08-22T14:04:54.760Z] 14:04:54 INFO - TEST-START | js/xpconnect/tests/unit/test_bug1082450.js
WARNING - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/unit/test_bug1082450.js | xpcshell return code: -11
INFO - TEST-INFO took 152ms
INFO - >>>>>>>
INFO - PID 9794 | [9794, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2632
INFO - PID 9794 | Couldn't convert chrome URL: chrome://branding/locale/brand.properties
INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
INFO - PID 9794 | [9794, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, kKnownEsrVersion) failed with result 0x80004002: file /builds/worker/workspace/build/src/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 662
INFO - PID 9794 | Assertion failure: introducerFn, at /builds/worker/workspace/build/src/obj-firefox/dist/include/js/CompileOptions.h:419
INFO - PID 9794 | ExceptionHandler::GenerateDump cloned child 9803
INFO - PID 9794 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
INFO - PID 9794 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
INFO - <<<<<<<
INFO - mozcrash Copy/paste: /builds/worker/workspace/build/linux64-minidump_stackwalk /tmp/xpc-other-kpwGLE/509bed02-cd3a-1804-0534-00388e2ac875.dmp /builds/worker/workspace/build/symbols
INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/509bed02-cd3a-1804-0534-00388e2ac875.dmp
INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/509bed02-cd3a-1804-0534-00388e2ac875.extra
WARNING - PROCESS-CRASH | js/xpconnect/tests/unit/test_bug1082450.js | application crashed [@ JS::CompileOptions::setIntroductionInfo(char const*, char const*, unsigned int, JSScript*, unsigned int)]
INFO - Crash dump filename: /tmp/xpc-other-kpwGLE/509bed02-cd3a-1804-0534-00388e2ac875.dmp
INFO - Operating system: Linux
INFO - 0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
INFO - CPU: amd64
INFO - family 6 model 85 stepping 4
INFO - 1 CPU
INFO - GPU: UNKNOWN
INFO - Crash reason: SIGSEGV /SEGV_MAPERR
INFO - Crash address: 0x0
INFO - Process uptime: not available
INFO - Thread 0 (crashed)
INFO - 0 libxul.so!JS::CompileOptions::setIntroductionInfo(char const*, char const*, unsigned int, JSScript*, unsigned int) [CompileOptions.h:6ba35efeddf6851cea089763577596bf54fde7ee : 419 + 0x29]
INFO - rax = 0x00007f0e2749e3ad rdx = 0x0000000000000000
INFO - rcx = 0x000055d09528bc40 rbx = 0x00007f0e27493af0
INFO - rsi = 0x00007f0e1ca37770 rdi = 0x00007f0e1ca36540
INFO - rbp = 0x00007fff5672ad50 rsp = 0x00007fff5672ad50
INFO - r8 = 0x00007f0e1ca37770 r9 = 0x00007f0e28dd2040
INFO - r10 = 0x0000000000000000 r11 = 0x0000000000000000
INFO - r12 = 0x00007fff5672ae80 r13 = 0x00007fff5672b248
INFO - r14 = 0x0000000000000000 r15 = 0x00007f0e1201a000
INFO - rip = 0x00007f0e245228ea
INFO - Found by: given as instruction pointer in context
INFO - 1 libxul.so!CreateDynamicFunction(JSContext*, JS::CallArgs const&, js::GeneratorKind, js::FunctionAsyncKind) [JSFunction.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 1790 + 0xe]
INFO - rbx = 0x00007f0e27493af0 rbp = 0x00007fff5672b080
INFO - rsp = 0x00007fff5672ad60 r12 = 0x00007fff5672ae80
INFO - r13 = 0x00007fff5672b248 r14 = 0x0000000000000000
INFO - r15 = 0x00007f0e1201a000 rip = 0x00007f0e244eac31
INFO - Found by: call frame info
INFO - 2 libxul.so!js::Function(JSContext*, unsigned int, JS::Value*) [JSFunction.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 1980 + 0xc]
INFO - rbx = 0x00007f0e1201a000 rbp = 0x00007fff5672b0b0
INFO - rsp = 0x00007fff5672b090 r12 = 0x00007f0e120c0000
INFO - r13 = 0x00007fff5672b248 r14 = 0x00007f0e1201a000
INFO - r15 = 0x00007f0e244ea960 rip = 0x00007f0e244eaa06
INFO - Found by: call frame info
INFO - 3 libxul.so!CallJSNative(JSContext*, bool ()(JSContext, unsigned int, JS::Value*), JS::CallArgs const&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 447 + 0x12]
INFO - rbx = 0x00007fff5672b200 rbp = 0x00007fff5672b130
INFO - rsp = 0x00007fff5672b0c0 r12 = 0x00007f0e120c0000
INFO - r13 = 0x00007fff5672b248 r14 = 0x00007f0e1201a000
INFO - r15 = 0x00007f0e244ea960 rip = 0x00007f0e242f8575
INFO - Found by: call frame info
INFO - 4 libxul.so!CallJSNativeConstructor(JSContext*, bool ()(JSContext, unsigned int, JS::Value*), JS::CallArgs const&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 463 + 0xe]
INFO - rbx = 0x00007f0e1201a000 rbp = 0x00007fff5672b180
INFO - rsp = 0x00007fff5672b140 r12 = 0x00007fff5672b140
INFO - r13 = 0x00007fff5672b190 r14 = 0x00007f0e244ea960
INFO - r15 = 0x00007fff5672b248 rip = 0x00007f0e2430c02f
INFO - Found by: call frame info
INFO - 5 libxul.so!InternalConstruct(JSContext*, js::AnyConstructArgs const&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 637 + 0xf]
INFO - rbx = 0x00007fff5672b248 rbp = 0x00007fff5672b1e0
INFO - rsp = 0x00007fff5672b190 r12 = 0xfffdffffffffffff
INFO - r13 = 0x00007fff5672b190 r14 = 0x00007f0e1201a000
INFO - r15 = 0xfffe800000000000 rip = 0x00007f0e242f9a9a
INFO - Found by: call frame info
INFO - 6 libxul.so!js::Construct(JSContext*, JS::Handle<JS::Value>, js::AnyConstructArgs const&, JS::Handle<JS::Value>, JS::MutableHandle<JSObject*>) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 695 + 0xb]
INFO - rbx = 0x00007fff5672b248 rbp = 0x00007fff5672b210
INFO - rsp = 0x00007fff5672b1f0 r12 = 0x00007f0e1201a000
INFO - r13 = 0x00007fff5672b2e0 r14 = 0x00007fff5672b2f0
INFO - r15 = 0x00007f0e1201a000 rip = 0x00007f0e242f9d65
INFO - Found by: call frame info
INFO - 7 libxul.so!js::ForwardingProxyHandler::construct(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) const [Wrapper.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 182 + 0x1d]
INFO - rbx = 0x00007fff5672b230 rbp = 0x00007fff5672b380
INFO - rsp = 0x00007fff5672b220 r12 = 0x00007f0e1201a000
INFO - r13 = 0x00007fff5672b2e0 r14 = 0x00007fff5672b720
INFO - r15 = 0x00007fff5672b240 rip = 0x00007f0e248db587
INFO - Found by: call frame info
INFO - 8 libxul.so!js::CrossCompartmentWrapper::construct(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) const [CrossCompartmentWrapper.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 259 + 0xe]
INFO - rbx = 0x0000000000000001 rbp = 0x00007fff5672b3f0
INFO - rsp = 0x00007fff5672b390 r12 = 0x0000000000000008
INFO - r13 = 0x00007f0e1201a000 r14 = 0x00007fff5672b720
INFO - r15 = 0x00007fff5672b590 rip = 0x00007f0e248a789a
INFO - Found by: call frame info
INFO - 9 libxul.so!xpc::JSXrayTraits::construct(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&, js::Wrapper const&) [XrayWrapper.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 0 + 0x16]
INFO - rbx = 0x0000000000000002 rbp = 0x00007fff5672b4d0
INFO - rsp = 0x00007fff5672b400 r12 = 0x00007fff5672b590
INFO - r13 = 0x00007fff5672b720 r14 = 0x00007fff5672b720
INFO - r15 = 0x00007f0e28963190 rip = 0x00007f0e20f9f804
INFO - Found by: call frame info
INFO - 10 libxul.so!js::Proxy::construct(JSContext*, JS::Handle<JSObject*>, JS::CallArgs const&) [Proxy.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 523 + 0x16]
INFO - rbx = 0x00007f0e1201a000 rbp = 0x00007fff5672b570
INFO - rsp = 0x00007fff5672b4e0 r12 = 0x00007fff5672b590
INFO - r13 = 0x00007f0e28641d98 r14 = 0x00007fff5672b4f0
INFO - r15 = 0x00007fff5672b720 rip = 0x00007f0e248cbadc
INFO - Found by: call frame info
INFO - 11 libxul.so!InternalConstruct(JSContext*, js::AnyConstructArgs const&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 650 + 0xb]
INFO - rbx = 0x00007fff5672b720 rbp = 0x00007fff5672b5d0
INFO - rsp = 0x00007fff5672b580 r12 = 0xfffdffffffffffff
INFO - r13 = 0x00007f0e28955148 r14 = 0x00007f0e1201a000
INFO - r15 = 0x00007fff5672b580 rip = 0x00007f0e242f9a49
INFO - Found by: call frame info
INFO - 12 libxul.so!Interpret(JSContext*, js::RunState&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 3075 + 0x8]
INFO - rbx = 0x00007f0e11242248 rbp = 0x00007fff5672bb80
INFO - rsp = 0x00007fff5672b5e0 r12 = 0x00007f0e1201a000
INFO - r13 = 0x0000000000000052 r14 = 0x00007f0e28955148
INFO - r15 = 0x0000000000000001 rip = 0x00007f0e242ecff4
INFO - Found by: call frame info
INFO - 13 libxul.so!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 424 + 0xb]
INFO - rbx = 0x00007f0e1201a000 rbp = 0x00007fff5672bbe0
INFO - rsp = 0x00007fff5672bb90 r12 = 0x00007fff5672bd90
INFO - r13 = 0x00007f0e12069800 r14 = 0x00007fff5672bc30
INFO - r15 = 0x00000410cefbab20 rip = 0x00007f0e242e2ea4
INFO - Found by: call frame info
INFO - 14 libxul.so!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 567 + 0x8]
INFO - rbx = 0x00000410cefbab20 rbp = 0x00007fff5672bc90
INFO - rsp = 0x00007fff5672bbf0 r12 = 0x00007fff5672bd90
INFO - r13 = 0x00007f0e12069800 r14 = 0x00007f0e1201a000
INFO - r15 = 0x0000000000000000 rip = 0x00007f0e242f7db8
INFO - Found by: call frame info
INFO - 15 libxul.so!js::jit::DoCallFallback(JSContext*, js::jit::BaselineFrame*, js::jit::ICCall_Fallback*, unsigned int, JS::Value*, JS::MutableHandle<JS::Value>) [BaselineIC.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 3229 + 0x8]
INFO - rbx = 0x0000000000000000 rbp = 0x00007fff5672c040
INFO - rsp = 0x00007fff5672bca0 r12 = 0x00007fff5672c068
INFO - r13 = 0x00007f0e11294170 r14 = 0x00007f0e1201a000
INFO - r15 = 0x00000000000000e7 rip = 0x00007f0e24c2586e
INFO - Found by: call frame info
INFO - 16 0x285ad4bf73e3
INFO - rbx = 0x0000285ad4c27dc8 rbp = 0x00007fff5672c0b8
INFO - rsp = 0x00007fff5672c050 r12 = 0x0000000000000008
INFO - r13 = 0x00007f0e112420a8 r14 = 0x00007f0e118f4231
INFO - r15 = 0x00007f0e1201a000 rip = 0x0000285ad4bf73e3
INFO - Found by: call frame info
INFO - 17 0x7f0e11294170
INFO - rbp = 0x00007fff5672c158 rsp = 0x00007fff5672c0c8
INFO - rip = 0x00007f0e11294170
INFO - Found by: previous frame's frame pointer
INFO - 18 0x285ad4beea64
INFO - rbp = 0x00007fff5672c1c0 rsp = 0x00007fff5672c168
INFO - rip = 0x0000285ad4beea64
INFO - Found by: previous frame's frame pointer
INFO - 19 libxul.so!js::jit::EnterBaselineInterpreterAtBranch(JSContext*, js::InterpreterFrame*, unsigned char*) [BaselineJIT.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 111 + 0x3b]
INFO - rbp = 0x00007fff5672c570 rsp = 0x00007fff5672c1d0
INFO - rip = 0x00007f0e24d1b7cb
INFO - Found by: previous frame's frame pointer
INFO - 20 libxul.so!Interpret(JSContext*, js::RunState&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 1991 + 0x8]
INFO - rbx = 0x00007f0e11242190 rbp = 0x00007fff5672cb20
INFO - rsp = 0x00007fff5672c580 r12 = 0x00007f0e1201a000
INFO - r13 = 0x00007fff5672c8c0 r14 = 0xfff9800000000000
INFO - r15 = 0x00007f0e28949630 rip = 0x00007f0e242e4695
INFO - Found by: call frame info
INFO - 21 libxul.so!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 424 + 0xb]
INFO - rbx = 0x00007f0e1201a000 rbp = 0x00007fff5672cb80
INFO - rsp = 0x00007fff5672cb30 r12 = 0x00007f0e2894e688
INFO - r13 = 0x00007f0e2894e658 r14 = 0x00007fff5672cbd0
INFO - r15 = 0x00000410cefba820 rip = 0x00007f0e242e2ea4
INFO - Found by: call frame info
INFO - 22 libxul.so!js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JSObject&, JS::Value const&, js::AbstractFramePtr, JS::Value*) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 786 + 0xb]
INFO - rbx = 0x00007f0e1201a000 rbp = 0x00007fff5672cc80
INFO - rsp = 0x00007fff5672cb90 r12 = 0x00007f0e2894e688
INFO - r13 = 0x00007f0e2894e658 r14 = 0x00007fff5672cbd0
INFO - r15 = 0x00007f0e2894e628 rip = 0x00007f0e242fab0b
INFO - Found by: call frame info
INFO - 23 libxul.so!js::Execute(JSContext*, JS::Handle<JSScript*>, JSObject&, JS::Value*) [Interpreter.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 819 + 0x28]
INFO - rbx = 0x0000000000000000 rbp = 0x00007fff5672ccf0
INFO - rsp = 0x00007fff5672cc90 r12 = 0x00007fff5672ccb8
INFO - r13 = 0x00007f0e1201a000 r14 = 0x00007fff5672cca0
INFO - r15 = 0x00007fff5672cd40 rip = 0x00007f0e242fb0ee
INFO - Found by: call frame info
INFO - 24 libxul.so!JS::EvaluateDontInflate(JSContext*, JS::ReadOnlyCompileOptions const&, JS::SourceText<mozilla::Utf8Unit>&, JS::MutableHandle<JS::Value>) [CompilationAndEvaluation.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 586 + 0x27d]
INFO - rbx = 0x00000410cefba820 rbp = 0x00007fff5672cf10
INFO - rsp = 0x00007fff5672cd00 r12 = 0x00007f0e2894e960
INFO - r13 = 0x00007f0e1201a000 r14 = 0x00007fff5672cd10
INFO - r15 = 0x00007fff5672cec0 rip = 0x00007f0e2444af9b
INFO - Found by: call frame info
INFO - 25 libxul.so!XRE_XPCShellMain(int, char**, char**, XREShellData const*) [XPCShellImpl.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 994 + 0x21]
INFO - rbx = 0x00007fff5672e450 rbp = 0x00007fff5672d340
INFO - rsp = 0x00007fff5672cf20 r12 = 0x0000000000000000
INFO - r13 = 0x00007f0e1201a000 r14 = 0x0000000000000017
INFO - r15 = 0x00007fff5672cfd0 rip = 0x00007f0e21009c48
INFO - Found by: call frame info
INFO - 26 xpcshell!main [xpcshell.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 65 + 0x14]
INFO - rbx = 0x00007fff5672d358 rbp = 0x00007fff5672d390
INFO - rsp = 0x00007fff5672d350 r12 = 0x000055d0951ebb00
INFO - r13 = 0x00007fff5672d470 r14 = 0x00007f0e14057c00
INFO - r15 = 0x0000000000000000 rip = 0x000055d0951ebcc7
INFO - Found by: call frame info
INFO - 27 libc-2.23.so + 0x20830
INFO - rbx = 0x0000000000000000 rbp = 0x000055d095261ed0
INFO - rsp = 0x00007fff5672d3a0 r12 = 0x000055d0951ebb00
INFO - r13 = 0x00007fff5672d470 r14 = 0x0000000000000000
INFO - r15 = 0x0000000000000000 rip = 0x00007f0e1c691830
INFO - Found by: call frame info
INFO - 28 xpcshell!frame_dummy + 0x30
INFO - rsp = 0x00007fff5672d3c0 rip = 0x000055d0951ebc50
INFO - Found by: stack scanning
INFO - 29 xpcshell!_GLOBAL__sub_I_TimeStamp.cpp [TimeStamp.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 67 + 0x1c]
INFO - rsp = 0x00007fff5672d3d8 rip = 0x000055d0951ebb00
INFO - Found by: stack scanning
INFO - 30 0x7fff5672d470
INFO - rbx = 0x13e4890906edc735 rbp = 0x000055d0951ebb00
INFO - rsp = 0x00007fff5672d3e0 rip = 0x00007fff5672d470
INFO - Found by: call frame info
INFO - 31 ld-2.23.so + 0x107db
INFO - rsp = 0x00007fff5672d430 rip = 0x00007f0e28d7f7db
INFO - Found by: stack scanning
INFO - 32 xpcshell!_GLOBAL__sub_I_TimeStamp.cpp [TimeStamp.cpp:6ba35efeddf6851cea089763577596bf54fde7ee : 67 + 0x1c]
INFO - rsp = 0x00007fff5672d448 rip = 0x000055d0951ebb00
INFO - Found by: stack scanning
INFO - 33 0x7fff5672d470
INFO - rbx = 0x0000000000000000 rbp = 0x000055d0951ebb00
INFO - rsp = 0x00007fff5672d450 rip = 0x00007fff5672d470
INFO - Found by: call frame info
INFO - 34 xpcshell!_start + 0x29
INFO - rsp = 0x00007fff5672d460 rip = 0x000055d0951ebb29
INFO - Found by: stack scanning

Ted Campbell [:tcampbell]

Assignee

Comment 16

•

5 years ago

There are cases that use DescribeScriptedCallerForCompilation without handling missing info similar to how CompileOptions::setIntroductionInfoToCaller does. I'll fix the existing behaviour to stop formatting filename as "<unknown> line 0 > Function" and do more testing for these exotic cases.

Flags: needinfo?(tcampbell)

Phabricator Automation

Updated

•

5 years ago

Attachment #9086508 - Attachment is obsolete: true

Ted Campbell [:tcampbell]

Assignee

Comment 17

•

5 years ago

Attached file Bug 1575055 - Remove unused CompileOptions::setIntroductionScript. r?jandem — Details

We should always use setIntroductionInfo instead.

Jan de Mooij [:jandem]

Updated

•

5 years ago

Blocks: 1582160

Pulsebot

Comment 18

•

5 years ago

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74ea9b874cda
Remove unused CompileOptions::setIntroductionScript. r=jandem
https://hg.mozilla.org/integration/autoland/rev/4e215473fc09
Privatize js::CompileOptions::strictMode. r=jandem
https://hg.mozilla.org/integration/autoland/rev/012adaacab67
Unify JS::CompileOptions::canLazilyParse and forceFullParse_. r=jandem
https://hg.mozilla.org/integration/autoland/rev/b36b8d13ebb9
Remove redundant overrides in ReadOnlyCompileOptions. r=jandem
https://hg.mozilla.org/integration/autoland/rev/5f8895bf4c3f
Avoid duplicating CompileOptions constructor code. r=jandem

Noemi Erli[:noemi_erli]

Comment 19

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/74ea9b874cda
https://hg.mozilla.org/mozilla-central/rev/4e215473fc09
https://hg.mozilla.org/mozilla-central/rev/012adaacab67
https://hg.mozilla.org/mozilla-central/rev/b36b8d13ebb9
https://hg.mozilla.org/mozilla-central/rev/5f8895bf4c3f

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox71: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla71

You need to log in before you can comment on or make changes to this bug.