Closed Bug 1575058 Opened 3 months ago Closed 3 months ago

Improve support for Error handling

Categories

(Core :: Web Replay, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: jlast, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently, it is quite common to see an error in the CLI output about error.unsafeDereference() being null here.

This patch fixes it, but exposes a heap of NYIs for error support here. It would be great to support this case.

              const rawError = error.unsafeDereference();
              errorMessage = rawError ? rawError.toString() : "";

STR:

  1. go to https://firefox-dev.tools/debugger-examples/examples/todomvc/
  2. warp back to a previous location
evaluateJSAsync threw an exception: Error: Encountered error while waiting for Helper Result: TypeError: error.unsafeDereference(...) is null
Stack: evaluateJSAsync/<@resource://devtools/server/actors/webconsole.js:1080:58
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
enter@resource://devtools/server/actors/utils/event-loop.js:80:18
_pushThreadPause@resource://devtools/server/actors/thread.js:250:15
_pauseAndRespond@resource://devtools/server/actors/thread.js:797:12
replayingOnForcedPause@resource://devtools/server/actors/thread.js:1837:12
replayTimeWarp/<@resource://devtools/server/actors/replay/debugger.js:233:12
_performResume@resource://devtools/server/actors/replay/debugger.js:364:15
Line: 1080, column: 58
console.error: (new Error("Encountered error while waiting for Helper Result: TypeError: error.unsafeDereference(...) is null", "resource://devtools/server/actors/webconsole.js", 1080))
Priority: -- → P3
Blocks: 1575065
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2429d4adb2df
Fix assorted bugs with showing errors in the console while replaying, r=loganfsmyth.
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → bhackett1024
You need to log in before you can comment on or make changes to this bug.