1575058 - Improve support for Error handling

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement, P3)

Description

[Jason Laster [:jlast]]

Currently, it is quite common to see an error in the CLI output about error.unsafeDereference() being null here.

This patch fixes it, but exposes a heap of NYIs for error support here. It would be great to support this case.

              const rawError = error.unsafeDereference();
              errorMessage = rawError ? rawError.toString() : "";

STR:

1. go to https://firefox-dev.tools/debugger-examples/examples/todomvc/
2. warp back to a previous location

evaluateJSAsync threw an exception: Error: Encountered error while waiting for Helper Result: TypeError: error.unsafeDereference(...) is null
Stack: evaluateJSAsync/<@resource://devtools/server/actors/webconsole.js:1080:58
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
enter@resource://devtools/server/actors/utils/event-loop.js:80:18
_pushThreadPause@resource://devtools/server/actors/thread.js:250:15
_pauseAndRespond@resource://devtools/server/actors/thread.js:797:12
replayingOnForcedPause@resource://devtools/server/actors/thread.js:1837:12
replayTimeWarp/<@resource://devtools/server/actors/replay/debugger.js:233:12
_performResume@resource://devtools/server/actors/replay/debugger.js:364:15
Line: 1080, column: 58
console.error: (new Error("Encountered error while waiting for Helper Result: TypeError: error.unsafeDereference(...) is null", "resource://devtools/server/actors/webconsole.js", 1080))

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1575058 - Fix assorted bugs with showing errors in the console while replaying, r=loganfsmyth.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2429d4adb2df
Fix assorted bugs with showing errors in the console while replaying, r=loganfsmyth.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2429d4adb2df