157508 - [FIX]Window not closed when user cancels PrintDialog

Status: RESOLVED WORKSFORME

(MailNews Core :: Printing, defect)

Description

[rods (gone)]

The DV now checks to see if the "document" is busy and "queues" the print
request request. This causes a problem for mail because we try to print from the
STOP notification. Which is fine, except if a user cancels the print dialog, the
windows never gets cleaned up. Also, I think this may cause problems when
printing multiple msgs.

Comment 1

[rods (gone)]

Attachment: patch

Adds a PLEvent to give the DV time to finish executing the STOP so the busy
flags get turned off and then we can have the DV execute the Print command
synchronously up to the print dialog instead of queueing it.

Comment 2

[Jean-Francois Ducarroz]

Comment on attachment 91332 [details] [diff] [review]
patch

R=ducarroz

Comment 3

[(not reading, please use [e-mail] instead)]

rods, sorry for the delay.  I'm having problems understanding.

Is the only problem when the user cancels the print dialog?  
What's the problem when we print multiple messages?
Can you explain why using a PL_Event fixes the problem?

If this fix turns out to be correct, this comment:

// If something bad happens here (menaing we can fire the PLEvent, highly unlikely)

should be:

// If something bad happens here (meaning we can't fire the PLEvent, highly
unlikely)

Comment 4

[rods (gone)]

More explanation beyond Comment #1:

The problem is that the MsgPrintEngine is being notified as a listener of
nsIWebProgressListener::STATE_STOP, and then calls Print on the DocumentViewer
(DV). The problem with this is that the DV checks to see if the document is
still busy, which it still is becuase the Doc's flags aren't reset to "not busy"
until after all the listeners are notified. The DV then "queues" the print
request because the document is busy. Later the Print happens but at that point
we have no way to tell the MsgPrintEngine that canceled happened.

The fix introduces the PLEvent so that the document can notify all the listeners
and then state the doc state to "not busy." So our PLEvent fires and says
"Print" the DV is no longer busy and the Print request doesn't get queued and
the return from the Print call is synchronuos with the proper error codes for
the MsgPrintEngine to do the right thing.

(BTW, we should copy these comments for documentation on mail printing)

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 91332 [details] [diff] [review]
patch

sr=sspitzer

Comment 6

[rods (gone)]

this was fixed as part of a different bug