157509 - No error on invalid usage of \ in identifiers

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Igor Bukanov]

Rhino does not throw SyntaxError on invalid \ usage in identifiers like in:

var a\b;

In general, as long as \ in the middle of the identifier does not follow by u,
Rhino silently swallow that:

try {
	eval("var a\\1 = 0; print(a\\1); ");
} catch (e) {
	print(e);
}

which prints 0 while SM correctly prints:

SyntaxError: illegal character

Comment 1

[Phil Schwartau]

Testcase added to JS testsuite:

          mozilla/js/tests/ecma_3/Statements/regress-157509.js

As Igor says, this is passing in SpiderMonkey, failing in Rhino -

Comment 2

[Igor Bukanov]

Attachment: TokenStream refactoring

I commited the patch with the following comments:
--
I changed TokenStream to use internal buffer in place of
LineBuffer#startString/
getString to store currently read characters for identifiers, strings and
number
s. For the price of yet another character coping it allows to simplify code
logi
c especially regarding interaction with LineBuffer.
--

Comment 3

[Igor Bukanov]

With the above patch commited Rhino passes
mozilla/js/tests/ecma_3/Statements/regress-157509.js

Comment 4

[Phil Schwartau]

Verified FIXED. Testcase now passes in both the rhino, rhinoi shells -

Comment 5

[Igor Bukanov]

Targeting as resolved against 1.5R4