Closed Bug 1575092 Opened 1 year ago Closed 3 months ago

A shared/service worker's containing process must respect COOP/COEP

Categories

(Core :: DOM: Workers, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: perry, Assigned: perry)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

No description provided.
See Also: → 1562663
See Also: 1562663
Depends on: 1579992

Preventing RemoteWorkerService from existing in "web COOP+COEP" content
processes prevents Shared Workers from being spawned in them because there
won't be an associated RemoteWorkerServiceParent that registers with the parent
process RemoteWorkerManager.

Depends on D50814

Blocks: 1595206
Attachment #9104650 - Attachment description: Bug 1575092 - add "web COOP+COEP" process type helpers r?nika → Bug 1575092 - add "web COOP+COEP" process type helpers r?asuth
Pushed by pjiang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e28e46ca4a17
add "web COOP+COEP" process type helpers r=asuth
https://hg.mozilla.org/integration/autoland/rev/8dc03b744500
don't spawn Shared/Service Workers in "web COOP+COEP" processes r=asuth
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
Regressions: 1596563
Regressions: 1596556

Backed out 2 changesets (bug 1575092) for causing Bug 1596556 and Bug 1596556.

Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=276235001&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/d4N9AOGMQmmyJnq9LTofQA/runs/0/artifacts/public/logs/live_backing.log

[task 2019-11-14T18:11:58.654Z] 18:11:58 INFO - PID 2321 | Assertion failure: !IsWebCoopCoepRemoteType(remoteType) (COOP+COEP processes don't support remote workers right now), at /builds/worker/workspace/build/src/dom/workers/remoteworkers/RemoteWorkerManager.cpp:245
[task 2019-11-14T18:11:59.017Z] 18:11:59 INFO - IOError on command, setting status to CRASH
[task 2019-11-14T18:11:59.056Z] 18:11:59 INFO - mozcrash Copy/paste: /Users/cltbld/tasks/task_1573753297/build/macosx64-minidump_stackwalk /var/folders/mx/sss0hh4x5wz4l5p242lvj5dw000017/T/tmp1dkvSH.mozrunner/minidumps/C671518A-7733-4D3C-B19B-9DAC236D99F3.dmp /Users/cltbld/tasks/task_1573753297/build/symbols
[task 2019-11-14T18:12:09.227Z] 18:12:09 INFO - mozcrash Saved minidump as /Users/cltbld/tasks/task_1573753297/build/blobber_upload_dir/C671518A-7733-4D3C-B19B-9DAC236D99F3.dmp
[task 2019-11-14T18:12:09.237Z] 18:12:09 INFO - mozcrash Saved app info as /Users/cltbld/tasks/task_1573753297/build/blobber_upload_dir/C671518A-7733-4D3C-B19B-9DAC236D99F3.extra
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - PROCESS-CRASH | /html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https.html | application crashed [@ mozilla::dom::RemoteWorkerManager::SelectTargetActorForServiceWorker(mozilla::dom::RemoteWorkerData const&) const]
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - Crash dump filename: /var/folders/mx/sss0hh4x5wz4l5p242lvj5dw000017/T/tmp1dkvSH.mozrunner/minidumps/C671518A-7733-4D3C-B19B-9DAC236D99F3.dmp
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - Operating system: Mac OS X
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - 10.14.5 18F132
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - CPU: amd64
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - family 6 model 69 stepping 1
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - 4 CPUs
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO -
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - GPU: UNKNOWN
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO -
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Crash reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Crash address: 0x0
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Process uptime: 41 seconds
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO -
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Thread 13 (crashed)
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - 0 XUL!mozilla::dom::RemoteWorkerManager::SelectTargetActorForServiceWorker(mozilla::dom::RemoteWorkerData const&) const [RemoteWorkerManager.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 243 + 0x29]
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rax = 0x00000001168c1537 rdx = 0x0000000000000000
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rcx = 0x000000010dca8158 rbx = 0x00000001228f9890
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rsi = 0x00000000000120a8 rdi = 0x00007fffa23bc028
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rbp = 0x000070000d4ccb60 rsp = 0x000070000d4cca30
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - r8 = 0x00000000000130a8 r9 = 0x00007fffa23bc048
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - r10 = 0x0000000000000000 r11 = 0x00007fffa23bc040
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - r12 = 0x0000000000000003 r13 = 0x000000012b67b790
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - r14 = 0x000000012b67b790 r15 = 0x00000001206edb80
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111eab786
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: given as instruction pointer in context
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 1 XUL!mozilla::dom::RemoteWorkerManager::Launch(mozilla::dom::RemoteWorkerController*, mozilla::dom::RemoteWorkerData const&, int) [RemoteWorkerManager.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 128 + 0xe]
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rbp = 0x000070000d4ccb90 rsp = 0x000070000d4ccb70
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111ea4b87
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: previous frame's frame pointer
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 2 XUL!mozilla::dom::RemoteWorkerController::Create(mozilla::dom::RemoteWorkerData const&, mozilla::dom::RemoteWorkerObserver*, int) [RemoteWorkerController.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 44 + 0x11]
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rbp = 0x000070000d4ccbd0 rsp = 0x000070000d4ccba0
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111ea4945
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: previous frame's frame pointer
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 3 XUL!mozilla::dom::RemoteWorkerControllerParent::RemoteWorkerControllerParent(mozilla::dom::RemoteWorkerData const&) [RemoteWorkerControllerParent.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 30 + 0xd]
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rbp = 0x000070000d4ccc00 rsp = 0x000070000d4ccbe0
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111ea8960
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: previous frame's frame pointer
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 4 XUL!mozilla::ipc::BackgroundParentImpl::AllocPRemoteWorkerControllerParent(mozilla::dom::RemoteWorkerData const&) [BackgroundParentImpl.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 513 + 0x18]
[task 2019-11-14T18:12:09.458Z] 18:12:09 INFO - rbp = 0x000070000d4ccc20 rsp = 0x000070000d4ccc10
[task 2019-11-14T18:12:09.458Z] 18:12:09 INFO - rip = 0x000000010eaafd62
[task 2019-11-14T18:12:09.458Z] 18:12:09 INFO - Found by: previous frame's frame pointer


Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=276235001&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/d4N9AOGMQmmyJnq9LTofQA/runs/0/artifacts/public/logs/live_backing.log

[task 2019-11-14T18:11:58.654Z] 18:11:58 INFO - PID 2321 | Assertion failure: !IsWebCoopCoepRemoteType(remoteType) (COOP+COEP processes don't support remote workers right now), at /builds/worker/workspace/build/src/dom/workers/remoteworkers/RemoteWorkerManager.cpp:245
[task 2019-11-14T18:11:59.017Z] 18:11:59 INFO - IOError on command, setting status to CRASH
[task 2019-11-14T18:11:59.056Z] 18:11:59 INFO - mozcrash Copy/paste: /Users/cltbld/tasks/task_1573753297/build/macosx64-minidump_stackwalk /var/folders/mx/sss0hh4x5wz4l5p242lvj5dw000017/T/tmp1dkvSH.mozrunner/minidumps/C671518A-7733-4D3C-B19B-9DAC236D99F3.dmp /Users/cltbld/tasks/task_1573753297/build/symbols
[task 2019-11-14T18:12:09.227Z] 18:12:09 INFO - mozcrash Saved minidump as /Users/cltbld/tasks/task_1573753297/build/blobber_upload_dir/C671518A-7733-4D3C-B19B-9DAC236D99F3.dmp
[task 2019-11-14T18:12:09.237Z] 18:12:09 INFO - mozcrash Saved app info as /Users/cltbld/tasks/task_1573753297/build/blobber_upload_dir/C671518A-7733-4D3C-B19B-9DAC236D99F3.extra
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - PROCESS-CRASH | /html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https.html | application crashed [@ mozilla::dom::RemoteWorkerManager::SelectTargetActorForServiceWorker(mozilla::dom::RemoteWorkerData const&) const]
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - Crash dump filename: /var/folders/mx/sss0hh4x5wz4l5p242lvj5dw000017/T/tmp1dkvSH.mozrunner/minidumps/C671518A-7733-4D3C-B19B-9DAC236D99F3.dmp
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - Operating system: Mac OS X
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - 10.14.5 18F132
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - CPU: amd64
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - family 6 model 69 stepping 1
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO - 4 CPUs
[task 2019-11-14T18:12:09.455Z] 18:12:09 INFO -
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - GPU: UNKNOWN
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO -
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Crash reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Crash address: 0x0
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Process uptime: 41 seconds
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO -
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - Thread 13 (crashed)
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - 0 XUL!mozilla::dom::RemoteWorkerManager::SelectTargetActorForServiceWorker(mozilla::dom::RemoteWorkerData const&) const [RemoteWorkerManager.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 243 + 0x29]
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rax = 0x00000001168c1537 rdx = 0x0000000000000000
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rcx = 0x000000010dca8158 rbx = 0x00000001228f9890
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rsi = 0x00000000000120a8 rdi = 0x00007fffa23bc028
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - rbp = 0x000070000d4ccb60 rsp = 0x000070000d4cca30
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - r8 = 0x00000000000130a8 r9 = 0x00007fffa23bc048
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - r10 = 0x0000000000000000 r11 = 0x00007fffa23bc040
[task 2019-11-14T18:12:09.456Z] 18:12:09 INFO - r12 = 0x0000000000000003 r13 = 0x000000012b67b790
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - r14 = 0x000000012b67b790 r15 = 0x00000001206edb80
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111eab786
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: given as instruction pointer in context
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 1 XUL!mozilla::dom::RemoteWorkerManager::Launch(mozilla::dom::RemoteWorkerController*, mozilla::dom::RemoteWorkerData const&, int) [RemoteWorkerManager.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 128 + 0xe]
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rbp = 0x000070000d4ccb90 rsp = 0x000070000d4ccb70
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111ea4b87
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: previous frame's frame pointer
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 2 XUL!mozilla::dom::RemoteWorkerController::Create(mozilla::dom::RemoteWorkerData const&, mozilla::dom::RemoteWorkerObserver*, int) [RemoteWorkerController.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 44 + 0x11]
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rbp = 0x000070000d4ccbd0 rsp = 0x000070000d4ccba0
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111ea4945
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: previous frame's frame pointer
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 3 XUL!mozilla::dom::RemoteWorkerControllerParent::RemoteWorkerControllerParent(mozilla::dom::RemoteWorkerData const&) [RemoteWorkerControllerParent.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 30 + 0xd]
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rbp = 0x000070000d4ccc00 rsp = 0x000070000d4ccbe0
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - rip = 0x0000000111ea8960
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - Found by: previous frame's frame pointer
[task 2019-11-14T18:12:09.457Z] 18:12:09 INFO - 4 XUL!mozilla::ipc::BackgroundParentImpl::AllocPRemoteWorkerControllerParent(mozilla::dom::RemoteWorkerData const&) [BackgroundParentImpl.cpp:8dc03b744500555e87b7506bd317a6c70438603c : 513 + 0x18]
[task 2019-11-14T18:12:09.458Z] 18:12:09 INFO - rbp = 0x000070000d4ccc20 rsp = 0x000070000d4ccc10
[task 2019-11-14T18:12:09.458Z] 18:12:09 INFO - rip = 0x000000010eaafd62
[task 2019-11-14T18:12:09.458Z] 18:12:09 INFO - Found by: previous frame's frame pointer

Flags: needinfo?(perry)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla72 → ---
Pushed by pjiang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/036e6a66c525
add "web COOP+COEP" process type helpers r=asuth
https://hg.mozilla.org/integration/autoland/rev/da39e98af6a2
don't spawn Shared/Service Workers in "web COOP+COEP" processes r=asuth
Flags: needinfo?(perry)
Status: REOPENED → RESOLVED
Closed: 3 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.