1575134 - Build failure on BSDs due to bug #1566778

Status: RESOLVED FIXED

(Testing :: Mozbase Rust, defect, P1)

Description

[Landry Breuil (:gaston)]

I dunno what was the intent of bug #1566778, but trying to build m-c on OpenBSD i get this build failure:

52:58.42 error[E0428]: the name `platform` is defined multiple times
52:58.42    --> testing/mozbase/rust/mozrunner/src/runner.rs:462:1
52:58.42     |
52:58.42 301 | pub mod platform {
52:58.42     | ---------------- previous definition of the module `platform` here
52:58.42 ...
52:58.42 462 | pub mod platform {
52:58.42     | ^^^^^^^^^^^^^^^^ `platform` redefined here
52:58.42     |
52:58.42     = note: `platform` must be defined only once in the type namespace of this module

cf http://buildbot.rhaalovely.net/nine/#/builders/1/builds/523/steps/8/logs/stdio

Was this actually tested ?

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We don't have CI to run tests on any platform including OpenBSD, as such this might have slipped through. But we will fix it for the 0.25 release of geckodriver. Thanks for reporting!

Andreas, can you please have a look?

Comment 2

[Andreas Tolfsen ❲:ato❳]

The fallback platform module guard probably needs to be updated
to unix instead of linux:
https://searchfox.org/mozilla-central/source/testing/mozbase/rust/mozrunner/src/runner.rs#461

Patches are accepted.

Comment 3

[Andreas Tolfsen ❲:ato❳]

On second thought, this is a problem for any platform that isn’t
Windows, macOS, or Linux.

Comment 4

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1575134: mozrunner: drop fallback firefox_default_path();

With bug 1566778 we started searching the system path on BSDs
similarly to how we had done it on Linux. The patch forgot to
remove the fallback implementation of the platform module, causing
a compile issue on BSDs since they are now covered by the same
implementation as what used to be Linux-specific.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/020f6f0f05d0
mozrunner: drop fallback firefox_default_path(); r=webdriver-reviewers,jgraham

Comment 6

[Landry Breuil (:gaston)]

Thanks, once this gets merged to m-c my buildbot will test it.

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/020f6f0f05d0