1575196 - The blank space are not recognized if are added at the beginning or at the end of the password

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: blankSpace_password.mp4

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-19) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Prerequisites]:

• The Firefox browser is opened.

[Steps to reproduce]:

1. Navigate to “about:logins” page.
2. Create a new login that contains a password with blank space characters at the beginning and the end. (e.g., “ 1234 “)
3. Click on the Show Password button from “Login Item” mode.
4. Observe the password.

[Expected result]:

• The password is correctly displayed.

[Actual result]:

• The blank space characters are not recognized.

[Notes]:

• The blank space characters are recognized only if they are added inside of the password.
• The issue is reproducible when creating a new login or editing an old one.
• Attached a screen recording with the issue.

Comment 1

[Matthew N. [:MattN]]

I think I saw that we were trimming the value now but that doesn't seem like a good idea for passwords. P2 since I think it's a regression compared to the old UI.

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1575196 - Stop trimming passwords when saving them. r=MattN

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1046eea513e
Stop trimming passwords when saving them. r=MattN

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c1046eea513e

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-23)(64-bit) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

• The blank space characters are now recognized.