Closed Bug 1575201 Opened 5 years ago Closed 5 years ago

Port |Bug 1040947 - Opening page info from a remote tab is sluggish| to SeaMonkey

Categories

(SeaMonkey :: Page Info, enhancement)

Product:
SeaMonkey
Component:
Page Info
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.68
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.63 --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 2 open bugs)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 4 obsolete files)

Switch to using message listeners v1.4
68.02 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Port the following:

  • Bug 1040947 - Opening page info from a remote tab is sluggish
  • Part of Bug 1175794 part 1 - Remove use of variables on this for pageinfo
  • Bug 1175794 part 2 - Remove use of variables on this for pageinfo
  • Bug 1175794 part 3 - Remove use of variables on this for pageinfo
  • Bug 1180991 - Send up natural dimensions of background images loaded in content for Page Info
  • Bug 1233885 - fix up docInfo and permission manager to use default user context
  • Bug 803330 - fix row count assertion failure in page info dialog
  • Part of Bug 1521170 - Add a rule that prevents calling some Array and String accessor methods without using the return value
Blocks: 1573595

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Sluggishness of page info
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Other patches yet to come on top of this, but from testing this performs as well as, if not better than, the existing code. It is a fairly big patch though.

Attachment #9087354 - Flags: review?(frgrahl)
Attachment #9087354 - Flags: approval-comm-release?
Attachment #9087354 - Flags: approval-comm-esr60?
Blocks: 1575830

Found an issue with viewing Frame Info when testing a follow-up patch, so corrected it.

Attachment #9087354 - Attachment is obsolete: true
Attachment #9087354 - Flags: review?(frgrahl)
Attachment #9087354 - Flags: approval-comm-release?
Attachment #9087354 - Flags: approval-comm-esr60?
Attachment #9087395 - Flags: review?(frgrahl)
Attachment #9087395 - Flags: approval-comm-release?
Attachment #9087395 - Flags: approval-comm-esr60?

One swap of this.window to window missed.

Attachment #9087395 - Attachment is obsolete: true
Attachment #9087395 - Flags: review?(frgrahl)
Attachment #9087395 - Flags: approval-comm-release?
Attachment #9087395 - Flags: approval-comm-esr60?
Attachment #9087457 - Flags: review?(frgrahl)
Attachment #9087457 - Flags: approval-comm-release?
Attachment #9087457 - Flags: approval-comm-esr60?
Depends on: 1573596
Depends on: 1576126

Additional changes were needed for:

  • the Feed tab
  • capturing if instance of HTMLEmbedElement and fixing gImageView.getCellProperties
  • fixing an issue with NodeFilters
Attachment #9087457 - Attachment is obsolete: true
Attachment #9087457 - Flags: review?(frgrahl)
Attachment #9087457 - Flags: approval-comm-release?
Attachment #9087457 - Flags: approval-comm-esr60?
Attachment #9087701 - Flags: review?(frgrahl)
Attachment #9087701 - Flags: approval-comm-release?
Attachment #9087701 - Flags: approval-comm-esr60?
Blocks: 1576147
Blocks: 1576411
Depends on: 1573960

Fixed issue with urlSecurityCheck in function getSelectedItems in pageInfo.js
Removed unused function openURL

Attachment #9087701 - Attachment is obsolete: true
Attachment #9087701 - Flags: review?(frgrahl)
Attachment #9087701 - Flags: approval-comm-release?
Attachment #9087701 - Flags: approval-comm-esr60?
Attachment #9089569 - Flags: review?(frgrahl)
Attachment #9089569 - Flags: approval-comm-release?
Attachment #9089569 - Flags: approval-comm-esr60?
Comment on attachment 9089569 [details] [diff] [review]
Switch to using message listeners v1.4

r/a=me
lgtm
Attachment #9089569 - Flags: review?(frgrahl)
Attachment #9089569 - Flags: review+
Attachment #9089569 - Flags: approval-comm-release?
Attachment #9089569 - Flags: approval-comm-release+
Attachment #9089569 - Flags: approval-comm-esr60?
Attachment #9089569 - Flags: approval-comm-esr60+
Blocks: 1578061

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/7a0523b39bc5
Port Bug 1040947 "Opening page info from a remote tab is sluggish" to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: