1575208 - NewTab changed - Notification PopUp is cropped

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Serge]

Attachment: NT.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Try to change?install an extension that changes New Tab page.
Observe notification.

Actual results:

Notification is cropped

Expected results:

Notification shouldn't be cropped.
Firefox 68.0.2 is not affected with this issue.

Comment 2

[Aliaksandr Zabrodski]

The following extension can be used as example to reproduce the issue:

• https://addons.mozilla.org/en-US/firefox/addon/tabby-cat-friend/

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

If this affects several extensions we should try to fix this for 70.

Comment 4

[Brian Grinstead [:bgrins]]

FWIW the buttons in the footer seem to have no intrinsic height. When removing the padding here they get completely hidden: https://searchfox.org/mozilla-central/rev/e5327b05c822cdac24e233afa37d72c0552dbbaf/toolkit/themes/shared/global.inc.css#79. I suspect this is related to popup-notification-button-container being CSS flexbox nested inside of a XUL flexbox, but I'm not sure why it only affects this popupnotification and not others.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Mark, can you help find an owner for this issue to try and get a fix into 70 before we ship? Thanks!

Comment 7

[Tim Nguyen :ntim]

overflow: visible; restores the old behaviour, but that's probably not the root issue here. I can publish a patch that does that tomorrow that we can land for now.

Comment 8

[Mark Striemer [:mstriemer]]

Attachment: Bug 1575208 - Fix partially hidden buttons in extension notification panels r?ntim,dao

Comment 10

[Tim Nguyen :ntim]

Comment on attachment 9092382 [details]
Bug 1575208 - Fix partially hidden buttons in extension notification panels r?ntim,dao

Beta/Release Uplift Approval Request

• User impact if declined: See https://bug1575208.bmoattachments.org/attachment.cgi?id=9086645
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open different extension notification popups:
  • New tab notification: https://addons.mozilla.org/en-US/firefox/addon/tabby-cat-friend/
  • Tab hiding extension like Tab groups: https://addons.mozilla.org/en-US/firefox/addon/simple-tab-groups/
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Applies some CSS that is already applied on the existing notification panels
• String changes made/needed: none

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df8432da490a
Fix partially hidden buttons in extension notification panels r=dao

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/df8432da490a

Comment 13

[Timea Cernea [:tbabos][inactive]]

Reproduced on affected Beta.0b6 on Windows 10 x64, MacOS 10.13 and Ubuntu 18.04.
Verified-fixed on latest Nightly 71.0a1 (2019-09-13) (64-bit) on all the above mentioned OS.
Waiting for uplift to Beta.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9092382 [details]
Bug 1575208 - Fix partially hidden buttons in extension notification panels r?ntim,dao

Fix for new regression in 70, verified in nightly, fine for uplift for beta 7.

Comment 15

[Tim Nguyen :ntim]

https://hg.mozilla.org/releases/mozilla-beta/rev/8058742d1138895a0f141a15af4589fc9eee9112

Comment 16

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on latest Beta 70.0b7 (64-bit) on all the above mentioned OS.
Closing this issue as Verified - Fixed.