1575219 - Remove unused FailurePath from BaselineCacheIRCompiler::emitCompareStringResult

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[André Bargull [:anba]]

BaselineCacheIRCompiler::emitCompareStringResult creates a FailurePath, but never uses it.

Comment 1

[Nicolas B. Pierron [:nbp]]

Matthew, do you want to mentor this issue as a good-first-bug?

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Can Do!

Comment 3

[Ayrton Muñoz]

Attachment: bug-1575219.patch

Hi Matthew, here's a patch for this. This is my first open-source contribution so let me know if I missed or misunderstood something.

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Hey Ayrton;

This looks like it's definitely on the right path. There's a couple steps yet.

You'll want to follow the walkthrough here, and links from there on setting up phabricator and mozilla's review tool moz-phab.

Before you submit the patch, your commit messages should look something like this

Bug 1575219 - Remove unused failure path from BaselineCacheIRCompiler::emitCompareStringResult r?mgaudet

That way, the patch will get linked to this bug as well as directed to me for review.

After you get that up, what'll happen is I'll download your patch, apply it and push it to the mozilla try server which is how we interact with our pre-delivery continuous integration testing. Then, once that's done, I'll approve your patch, and submit it for landing, assuming everything goes smoothly.

Then after that we'll have to find you something new to work on!

Comment 5

[Ayrton Muñoz]

Attachment: Bug 1575219 - Remove unused failure path from BaselineCacheIRCompiler::emitCompareStringResult r?mgaudet

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64109c67702a
Remove unused failure path from BaselineCacheIRCompiler::emitCompareStringResult r=mgaudet

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/64109c67702a