1575263 - Fix clippy lint issues for geckodriver

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P2)

Description

[James Graham [:jgraham]]

Install clippy like:

rustup component add clippy --toolchain stable-x86_64-unknown-linux-gnu

(although on mac it's probably a different toolchain; look at the error message from cargo clippy to find out). Then run cargo clippy in testing/geckodriver. I think this ends up running on all the dependencies (and maybe some other stuff in the workspace), but it should be possible to fix everything under geckodriver, webdriver and mozbase/rust.

Comment 1

[Andreas Tolfsen ❲:ato❳]

cargo fix might be useful to automatically apply some of the
suggestions from rustc and clippy.

Comment 2

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Lint fixes with clippy and cargo fix

Some of the code inside of testing/geckodriver failed/raised clippy linting errors.
Here are some minor changes to fix most of the linting issues raised by clippy.

Comment 3

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Removed Clone on Copy types r=jgraham

Comment 4

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Use _else variants of ok_or, unwrap_or, etc. to lazy evaluate functions. r=jgraham

Depends on D43938

Comment 5

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Remove redundant field names r=jgraham

Depends on D43939

Comment 6

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Use assignment operators instead of longer form r=jgraham

Depends on D43940

Comment 7

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Improve use of references based on Clippy suggestions r=jgraham

Depends on D43941

Comment 8

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Lint fixes with clippy and cargo fix r=jgraham

Depends on D43942

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edd08f5d1fc2
Removed Clone on Copy types r=jgraham
https://hg.mozilla.org/integration/autoland/rev/f23040442548
Use _else variants of ok_or, unwrap_or, etc. to lazy evaluate functions. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/389d3e7d277a
Remove redundant field names r=jgraham
https://hg.mozilla.org/integration/autoland/rev/2c2e8bf45df9
Use assignment operators instead of longer form r=jgraham
https://hg.mozilla.org/integration/autoland/rev/47ce7a659a1f
Improve use of references based on Clippy suggestions r=jgraham
https://hg.mozilla.org/integration/autoland/rev/27322845983b
Lint fixes with clippy and cargo fix r=jgraham

Comment 10

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Change to_ to into_ to suit naming convention regarding self methods r=jgraham

Comment 11

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Move closure out of if statement r=jgraham

Depends on D43970

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55378cbba628
Change to_ to into_ to suit naming convention regarding self methods r=jgraham
https://hg.mozilla.org/integration/autoland/rev/62c8064a6be0
Move closure out of if statement r=jgraham

Comment 13

[David Heiberg [:dheiberg]]

There are still some issues in testing/geckodriver/marionette, looking into them now as part of this bug since it's part of the same dir

Comment 14

[David Heiberg [:dheiberg]]

Attachment: Bug 1575263 - Allow clippy double option, remove redundant let binding r=jgraham

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89a456a83002
Allow clippy double option, remove redundant let binding r=jgraham

Comment 16

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/edd08f5d1fc2
https://hg.mozilla.org/mozilla-central/rev/f23040442548
https://hg.mozilla.org/mozilla-central/rev/389d3e7d277a
https://hg.mozilla.org/mozilla-central/rev/2c2e8bf45df9
https://hg.mozilla.org/mozilla-central/rev/47ce7a659a1f
https://hg.mozilla.org/mozilla-central/rev/27322845983b

Comment 17

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/55378cbba628
https://hg.mozilla.org/mozilla-central/rev/62c8064a6be0
https://hg.mozilla.org/mozilla-central/rev/89a456a83002

Comment 18

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/edd08f5d1fc2
https://hg.mozilla.org/releases/mozilla-beta/rev/f23040442548
https://hg.mozilla.org/releases/mozilla-beta/rev/389d3e7d277a
https://hg.mozilla.org/releases/mozilla-beta/rev/2c2e8bf45df9
https://hg.mozilla.org/releases/mozilla-beta/rev/47ce7a659a1f
https://hg.mozilla.org/releases/mozilla-beta/rev/27322845983b
https://hg.mozilla.org/releases/mozilla-beta/rev/55378cbba628
https://hg.mozilla.org/releases/mozilla-beta/rev/62c8064a6be0
https://hg.mozilla.org/releases/mozilla-beta/rev/89a456a83002

Comment 19

[Andreas Tolfsen ❲:ato❳]

This is not a complaint, but I don’t entirely understand why this was uplifted to beta?

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Andreas Tolfsen 「:ato」 from comment #19)

This is not a complaint, but I don’t entirely understand why this was uplifted to beta?

That was just a sync between Nightly 70 and Beta 70, which happened several times between the first merge from central to beta, and the final version bump on central to 71. It's used to produce the developer edition builds.