Closed
Bug 1575288
Opened 5 years ago
Closed 5 years ago
_shutdown_sccache tries to shutdown sccache in the wrong location
Categories
(Firefox Build System :: Task Configuration, defect)
Firefox Build System
Task Configuration
Tracking
(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox68 unaffected, firefox69 unaffected, firefox70 fixed)
RESOLVED
FIXED
mozilla70
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | fixed |
People
(Reporter: erahm, Assigned: glandium)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
_shutdown_sccache
manually builds the path of the sccache
executable when attempting to shut it down. With the update to use the fetch
mechanism to install sccache
we now have it in different path. This causes failures on try, but doesn't seem to cause a build failure on central, although there's still an error in the build log.
Example failure on try:
[task 2019-08-20T17:07:53.284Z] 17:07:53 INFO - Copy/paste: z:\build\build\src\sccache\sccache.exe --stop-server
[task 2019-08-20T17:07:53.285Z] 17:07:53 ERROR - caught OS error 2: The system cannot find the file specified while running ['z:\\build\\build\\src\\sccache\\sccache.exe', '--stop-server']
[task 2019-08-20T17:07:53.285Z] 17:07:53 INFO - Running post-run listener: _summarize
[task 2019-08-20T17:07:53.285Z] 17:07:53 INFO - # TBPL SUCCESS #
[task 2019-08-20T17:07:53.285Z] 17:07:53 INFO - [mozharness: 2019-08-20 17:07:53.285000Z] FxDesktopBuild summary:
[task 2019-08-20T17:07:53.285Z] 17:07:53 INFO - # TBPL SUCCESS #
[fetches 2019-08-20T17:07:53.299Z] removing z:/build/fetches
Traceback (most recent call last):
File "run-task", line 861, in <module>
sys.exit(main(sys.argv[1:]))
File "run-task", line 856, in main
shutil.rmtree(fetches_dir)
File "C:\mozilla-build\python3\lib\shutil.py", line 494, in rmtree
return _rmtree_unsafe(path, onerror)
File "C:\mozilla-build\python3\lib\shutil.py", line 384, in _rmtree_unsafe
_rmtree_unsafe(fullname, onerror)
File "C:\mozilla-build\python3\lib\shutil.py", line 389, in _rmtree_unsafe
onerror(os.unlink, fullname, sys.exc_info())
File "C:\mozilla-build\python3\lib\shutil.py", line 387, in _rmtree_unsafe
os.unlink(fullname)
PermissionError: [WinError 5] Access is denied: 'z:/build/fetches\\sccache\\sccache.exe'
Note it's trying to run z:\build\build\src\sccache\sccache.exe
but then tries to delete z:/build/fetches\\sccache\\sccache.exe
which is of course still running.
On central it doesn't totally fail:
[task 2019-08-20T05:31:45.919Z] 05:31:45 INFO - Copy/paste: z:\build\build\src\sccache\sccache.exe --stop-server
[task 2019-08-20T05:31:45.919Z] 05:31:45 ERROR - caught OS error 2: The system cannot find the file specified while running ['z:\\build\\build\\src\\sccache\\sccache.exe', '--stop-server']
[task 2019-08-20T05:31:45.919Z] 05:31:45 INFO - Running post-run listener: _summarize
[task 2019-08-20T05:31:45.919Z] 05:31:45 INFO - # TBPL SUCCESS #
[task 2019-08-20T05:31:45.920Z] 05:31:45 INFO - [mozharness: 2019-08-20 05:31:45.919000Z] FxDesktopBuild summary:
[task 2019-08-20T05:31:45.920Z] 05:31:45 INFO - # TBPL SUCCESS #
[fetches 2019-08-20T05:31:45.934Z] removing z:/build/fetches
Flags: needinfo?(mh+mozilla)
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → mh+mozilla
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/ad0431949452 Shutdown sccache from the right place after bug 1573435. r=nalexander
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Updated•5 years ago
|
Keywords: regression
Updated•5 years ago
|
status-firefox68:
--- → unaffected
status-firefox69:
--- → unaffected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•