Closed Bug 1575328 Opened 5 months ago Closed 10 days ago

Fix usage of nsIDocShellTreeItem in nsDocShell::SetMixedContentChannel

Categories

(Core :: DOM: Navigation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla74
Fission Milestone M6
Tracking Status
firefox74 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#5394

This is lesser priority, as it seems to be mostly a sanity check and warning message, which may not be printed post-fission.

Here, we ensure that the current process is the same-type root of the docshell tree, and dump a warning if it is not. That warning may not show up post-fission if the parent is out of process, and the code erroneously thinks this docshell is the same-type root.

This should be fixed to use the BrowsingContext tree to determine whether this docshell is the same-type root.

Component: DOM: Core & HTML → Document Navigation
Fission Milestone: --- → M5
Priority: -- → P3
Priority: P3 → P2
Whiteboard: [rm-docshell-tree-item:simple]
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1c6e742f88eb
Fix usage of nsIDocShellTreeItem in nsDocShell::SetMixedContentChannel. r=kmag
Status: ASSIGNED → RESOLVED
Closed: 10 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.