1575335 - Figure out if a script is tracking without copying the script name

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task)

Description

[Andrew McCreight [:mccr8]]

In bug 1574972, I'm making nsJSUtils::GetCallingLocation() more fallible, because it creates a copy of the string, and there are crashes in the wild on Android where the script file name is 300KB or more.

Most places that call these methods are just doing it for error reporting, but Olli pointed out that two places are both doing more than just reporting an error, and don't actually need to keep the string alive, so the copy is unnecessary:
https://searchfox.org/mozilla-central/rev/03853a6e87c4a9405fce1de49e5d03b9e7a7a274/dom/xhr/XMLHttpRequestMainThread.cpp#2417,2430,2434
https://searchfox.org/mozilla-central/rev/03853a6e87c4a9405fce1de49e5d03b9e7a7a274/dom/fetch/Fetch.cpp#483-484

Comment 1

[Andrew McCreight [:mccr8]]

Ehsan said he could put a patch together.

Comment 2

[(no longer active)]

Attachment: Bug 1575335 - Avoid creating an extra copy of the file name URI when checking whether the currently running script is from a tracker;

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c98667d7a9a8
Avoid creating an extra copy of the file name URI when checking whether the currently running script is from a tracker; r=smaug

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/c98667d7a9a8