Open Bug 1575368 Opened 5 years ago Updated 2 years ago

Upgrade Clang-format used by NSS to that of Mozilla-Central

Categories

(NSS :: Libraries, task, P2)

Tracking

(Not tracked)

People

(Reporter: jcj, Unassigned)

References

Details

It would be helpful if Phabricator could verify clang-format compliance during code review, however that team has requested us to move forward to the same version of clang-format as is used by mozilla-central to simplify their deployment.

This bug is to evaluate moving forward to that version, and sub-tasks would be to upgrade the version in the NSS mach, and whatever further was necessary for Phabricator support.

What version is that?

The last time we looked at this, the concern was that clang-format 6 (and maybe 7) were damaging array declarations. There was an open clang-format bug that was affecting things apparently (which I can't find now, sadly).

FWIW, I don't see a move to Google style being viable for NSS, unless things have changed since we instituted the current regime. I'd personally be OK with that for the same reasons underlying the move in gecko, but if we go there, we'd need to work out how to land a big restyling patch.

I'll have to look, I think 8.0.1 -- I just wanted to put this into my medium-term memory (e.g., a Bug) before I totally forgot my conversation with Sylvestre on this subject.

Blocks: 1766907
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.