1575386 - [Fission] Frame contents are sometimes missing from saved pages with SingleFile

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect, P3)

Description

[Gildas Lormeau]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1 - Install SingleFile from https://addons.mozilla.org/firefox/addon/single-file
2 - Go to https://www.psl.com/job?gh_jid=4338490002&gh_src=936dd41f2
3 - Save the page with SingleFile
4 - Open the saved page

Actual results:

The main content is not saved. The page uses a iframe tag to embed this content.

Expected results:

The main content should be saved.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not sure how this is related but using the default "Save As" feature of Firefox, also fails. But it happens immediately, and not a single file gets created on disk. Checking the console there is even no error / warning reported. The download manager just mentions that the download has been failed.

Mike and Nika, do you think that should be files as a separate bug, or can both situations (Firefox, and WebExtension API) be related?

Comment 2

[Pablo]

Hi, i tried to replicate this using Windows10 64bit and with the latest firefox nightly 70.0.a1 and i was able to download the html

Using SingleFile it created a 1.9mb html (attached to this bug)
Using Save_as built in feature of firefox it created a 11kb file. (also attached to this bug)

can you check and let me know if the singlefile html is not good?

thanks
Pablo

Comment 3

[Pablo]

Attachment: SingleFile.html

Comment 4

[Pablo]

Attachment: Save_as.html

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Pablo from comment #2)

Hi, i tried to replicate this using Windows10 64bit and with the latest firefox nightly 70.0.a1 and i was able to download the html

Did you try it with Fission-enabled? (fission.autostart set to true, and then restart). I might be misinterpreting the bug, but I believe this is a Fission-only regression.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

I filed bug 1576188 about getting Save Page As working with Fission-enabled on sites with cross-domain iframes.

Comment 7

[Tomislav Jovanovic :zombie]

I misunderstood the description, this likely doesn't depend on 1576188, but likely does on fission-webext.

Comment 8

[Pablo]

When i enabled Fission in about:config i was able to replicate the problem with the latest firefox nightly release
attached is the save file created that has missing content.

Windows10 64bit
Firefox Nightly 70.0a1 and 71.0a1 issue is reproducible

Ubuntu 18.04 64bit
Firefox Nightly 70.0a1 and 71.0a1 issue is reproducible

Macos 10.14
Firefox Nightly 70.0a1 and 71.0a1 issue is reproducible

Comment 9

[Pablo]

Attachment: Careers (2019-09-02 4_28_15 PM).html

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 11

[Chris Peterson [:cpeterson]]

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 13

[Neha Kochar [:neha]]

Tom, is this still broken and do we know why?

Comment 14

[Tomislav Jovanovic :zombie]

This should be fixed now after changes in bug 1587541 and related bugs, I was able to confirm the extension working with cross-origin OOP iframes with Fission enabled.

The original STR link is not working anymore, Gildas can you please verify this works for you now?

Comment 15

[Neha Kochar [:neha]]

Closing based on comment 14 saying it is fixed now and no longer reproducible.