De/serialize ProfilerMarkerPayloads
Categories
(Core :: Gecko Profiler, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(2 files)
Instead of keeping pointers to payloads, we will serialize them straight into the ProfileBuffer's BlocksRingBuffer, and the payloads can be deleted.
Then when writing the profile out, we will deserialize them so they can stream themselves to JSON.
Note that this is just the first step to implement bug 1562604: Eventually we should be able to serialize the payload data without having to create a heap object first, and we will also be able to convert that serialization into JSON without having to recreate payload objects.
(The dependence on bug 1551313 is just to let that bug land before I change the pure virtual interface here.)
|
Assignee | |
Comment 2•5 years ago
|
||
The common data members stored in the ProfilerMarkerPayload base class can be
gathered into a struct, which will make it easier to pass around, especially
when a derived object is constructed with these common properties.
Depends on D43426
|
|
Assignee | |
Comment 3•5 years ago
|
||
Payloads will serialize themselves into a BlocksRingBuffer entry when first
captured.
Later they will be deserialized, to stream JSON for the output profile.
Depends on D43427
|
|
Assignee | |
Comment 4•5 years ago
|
||
Note to self: Bug 1577887 is adding 2 payloads.
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b0d726f2dd6 ProfilerMarkerPayload::CommonProps - r=gregtatum https://hg.mozilla.org/integration/autoland/rev/e8323157c6f3 De/serialize ProfilerMarkerPayload derived objects - r=gregtatum
|
||
Comment 6•5 years ago
|
||
Backed out 21 changesets (Bug 1578327, Bug 1575448, Bug 1580091, Bug 1576554, Bug 1581049, Bug 1576551, Bug 1578329, Bug 1576555) for platform.cpp related bustage
Backout link: https://hg.mozilla.org/integration/autoland/rev/9c10aac0356842219e95d1f6deb0bf7e7baed334
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266985776&repo=autoland&lineNumber=53923
Pushed by gsquelart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dc60a44ad0d1 ProfilerMarkerPayload::CommonProps - r=gregtatum https://hg.mozilla.org/integration/autoland/rev/143ee9e15b70 De/serialize ProfilerMarkerPayload derived objects - r=gregtatum
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dc60a44ad0d1
https://hg.mozilla.org/mozilla-central/rev/143ee9e15b70
Description
•