1575483 - Force LTR the homepage url for extensions

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Itiel]

Attachment: Screenshot

On extensions where the url ends with a backslash, you'd see the attached on RTL. So the url should be hardcoded as LTR for all cases.

Comment 1

[Itiel]

Adding this:

.addon-detail-row.addon-detail-row-homepage > a:dir(rtl) {
  direction: ltr;
}

here:
https://searchfox.org/mozilla-central/rev/03853a6e87c4a9405fce1de49e5d03b9e7a7a274/toolkit/mozapps/extensions/content/aboutaddons.css#313
should fix it.

Comment 2

[Itiel]

Attachment: Bug 1575483 - Force LTR the homepage url for extensions

Comment 3

[Jim Mathies [:jimm]]

I'm not qualified to review this. I can find a reviewer but first we need UX input on this.

Comment 4

[Tim Nguyen :ntim]

Ehsan, should URLs be forced to LTR direction or should they use dir="auto"?

(side note: it would be nice if we had some doc that summed up RTL UX on different elements like URLs/inputs/passwords so we can avoid needinfo'ing you all the time for guidance) :)

Comment 5

[Itiel]

(In reply to Tim Nguyen :ntim from comment #4)

Ehsan, should URLs be forced to LTR direction or should they use dir="auto"?

tbh I don't mind if URL here would be dir=auto as it'd be LTR automatically anyway in 99% of cases.

Comment 6

[(no longer active)]

(In reply to Tim Nguyen :ntim from comment #4)

Ehsan, should URLs be forced to LTR direction or should they use dir="auto"?

Full URLs (including the scheme before the host name and the slash afterwards) must always be displayed in LTR mode.

(side note: it would be nice if we had some doc that summed up RTL UX on different elements like URLs/inputs/passwords so we can avoid needinfo'ing you all the time for guidance) :)

Perhaps we should, yes. I unfortunately don't really have enough time to start that initiative myself, but if someone else does I would be happy to help provide input. There are a few other folks in the community who can probably help as well, such as Itiel, Tomer Cohen, Ahmed Nefzaoui, Amir Farsi, Arash Mousavi (and others whose names I'm forgetting at the moment), and a (now dormant seemingly) mailing list. :-)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97e8ad896431
Force LTR the homepage url for extensions r=mstriemer

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/97e8ad896431

Comment 9

[Alex Cornestean]

Verified the fix using the latest Nightly (71.0a1/20190904163258) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.

The ending backslash is now properly positioned LTR, at the right end of the URL, confirming the fix.