Closed Bug 1575487 Opened 5 years ago Closed 5 years ago

In dark theme, tag color doesn't come through for unread message unless the message is selected

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird_esr68 68+ fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: wsmwk, Assigned: Paenglab)

References

Details

(Whiteboard: smoketest68.0)

Attachments

(1 file)

Use dark theme.
Have an unread and a read message both tagged.

Both messages unselected - the read message shows the tagged color, the unread message does not show the tag color.

In default theme, both messages show tag color

Flags: needinfo?(richard.marti)

We should apply the white colour only on untagged messages.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Attachment #9087149 - Flags: review?(alessandro)
Attachment #9087149 - Flags: approval-comm-esr68?
Attachment #9087149 - Flags: approval-comm-beta?
Comment on attachment 9087149 [details] [diff] [review]
1575487-untagged-apply-unread.patch

Review of attachment 9087149 [details] [diff] [review]:
-----------------------------------------------------------------

Good work, this fixes the issue.
Please, fix the commit message as it seems to have a typo.
Attachment #9087149 - Flags: review?(alessandro) → review+

Jörg, please change the commit message on check-in to: Bug 1575487 - Apply on the dark theme the unread color only on untagged messages. r=aleca
Or a better one, when it sounds ugly.

Keywords: checkin-needed
Attachment #9087149 - Flags: approval-comm-esr68?
Attachment #9087149 - Flags: approval-comm-esr68+
Attachment #9087149 - Flags: approval-comm-beta?
Attachment #9087149 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 70.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b38987582780
For the dark theme apply the unread color only to untagged messages. r=aleca DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: