In dark theme, tag color doesn't come through for unread message unless the message is selected
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)
People
(Reporter: wsmwk, Assigned: Paenglab)
References
Details
(Whiteboard: smoketest68.0)
Attachments
(1 file)
1.09 KB,
patch
|
aleca
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
Use dark theme.
Have an unread and a read message both tagged.
Both messages unselected - the read message shows the tagged color, the unread message does not show the tag color.
In default theme, both messages show tag color
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
We should apply the white colour only on untagged messages.
Comment 2•5 years ago
|
||
Comment on attachment 9087149 [details] [diff] [review] 1575487-untagged-apply-unread.patch Review of attachment 9087149 [details] [diff] [review]: ----------------------------------------------------------------- Good work, this fixes the issue. Please, fix the commit message as it seems to have a typo.
Assignee | ||
Comment 3•5 years ago
|
||
Jörg, please change the commit message on check-in to: Bug 1575487 - Apply on the dark theme the unread color only on untagged messages. r=aleca
Or a better one, when it sounds ugly.
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b38987582780
For the dark theme apply the unread color only to untagged messages. r=aleca DONTBUILD
Comment 5•5 years ago
|
||
TB 69 beta 4:
https://hg.mozilla.org/releases/comm-beta/rev/b3dd2e75e3268e2c6cb459808b94dc303c163269
Comment 6•5 years ago
|
||
TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/144868a86847b0cc5444e9289590f0245cf03eeb
Description
•