Open Bug 1575492 Opened 5 years ago Updated 3 months ago

Fix up tests landed in bug 1561502 to avoid relying on behaviour of the channel converter that isn't guaranteed

Categories

(DevTools :: JSON Viewer, task)

task

Tracking

(Not tracked)

People

(Reporter: Gijs, Unassigned)

References

Details

Attachments

(1 obsolete file)

This is https://hg.mozilla.org/mozilla-central/file/tip/devtools/client/jsonview/test/browser_jsonview_data_blocking.js and specifically the 2 last test tasks in there.

From the review:

The converter calls onDataAvailable synchronously from onStartRequest.

This is not guaranteed to happen per the contract, so if we can avoid depending on that it would be good...

Ideally both of these would use a "real" channel, with only minimal parts modified. I struggled to figure out how to do this, in part because I couldn't find clear docs of how the stream converter is normally invoked and who's responsible for what. In fact, it seemed like there were two "directions" to use it in and the behaviour was significantly different in those 2 cases, but I didn't get much further than that...

Severity: normal → S3
Attachment #9387636 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: