1575495 - Clean up around `nsPlainTextSerializer::mAtFirstColumn`

Status: RESOLVED FIXED

(Core :: DOM: Serializers, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1575495: part 1) Simplify assignments to `mAtFirstColumn`. r=hsivonen

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1575495: part 2) Move `MaybeReplaceNbspsForOutput` to `CurrentLineContent`. r=hsivonen

Depends on D42837

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1575495: part 3) Sync argument names of declaration and definition of `DoAddText`. r=hsivonen

Depends on D42838

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1575495: part 4) Add `AddLineBreak` to `CurrentLineContent`. r=hsivonen

Depends on D42839

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1575495: part 5) Add comment to `setWrapColumn` that value 0 disables wrapping. r=hsivonen

Depends on D42840

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0fd980b158e3
part 1) Simplify assignments to `mAtFirstColumn`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/149e16997325
part 2) Move `MaybeReplaceNbspsForOutput` to `CurrentLineContent`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/4f533bb70026
part 3) Sync argument names of declaration and definition of `DoAddText`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/60893d2dc2d5
part 4) Add `AddLineBreak` to `CurrentLineContent`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/03f0d2688604
part 5) Add comment to `setWrapColumn` that value 0 disables wrapping. r=hsivonen

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/0fd980b158e3
https://hg.mozilla.org/mozilla-central/rev/149e16997325
https://hg.mozilla.org/mozilla-central/rev/4f533bb70026
https://hg.mozilla.org/mozilla-central/rev/60893d2dc2d5
https://hg.mozilla.org/mozilla-central/rev/03f0d2688604