Closed Bug 1575511 Opened 8 months ago Closed 8 months ago

Remove the highlight feature of Marionette screenshots

Categories

(Testing :: Marionette, task, P1)

70 Branch
task

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

This feature was used in the past by some l10n tests to highlight elements for localized builds of Firefox, eg. for missing access keys, or cut-off elements.

Given that we no longer run those tests there isn't actually a need to keep this code in Marionette. It would also help me a lot with the refactoring on bug 1559592.

Lets just kill the code!

The feature was used in the past to highlight broken elements for l10n
specific tests. Given that those tests don't exist anymore (for already
a long time) the highlight feature doesn't have to be kept alive.

Also it isn't covered by the WebDriver spec, and as such a custom feature
which is not worth keeping its code working. Especially with the Fission
work upcoming.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ab60925635c
[marionette] Remove feature to highlight elements in screenshots. r=webdriver-reviewers,ato
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.