1575592 - "Confirm before closing multiple tabs" does not confirm when selecting all tabs in a window, then closing them - and closing the window as a result

Status: RESOLVED WORKSFORME

(Firefox :: Tabbed Browser, defect, P5)

Description

[illumilor.e]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

When right click tab then "s" to select all, right click again and "s" will close all tabs in a window without warning even though warn when closing multiple tabs is selected

Comment 1

[Alice0775 White]

I can reproduce.
And after re-launch browser, it is not possible to restore these closed tab.
So this is bug due to Bug 1135303.

From UX consistency point of view, Bug 1135303 should be disabled I think.

Dão, Can you please look into this?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Hey Brian, what do you think about showing a "Undo" button in the tabbar when multiple tabs are closed? Upon clicking this button the tabs would be restored.

We could place the button to the right of the New Tab button. If the tab bar is full this would cause the tabs to shift though.

Or we could temporarily change the New Tab button to an undo button, which after a timeout it goes back to being the New Tab button? This would prevent the tabs from shifting.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

Inactive users most likely will not respond; if the missing information is essential and cannot be collected another way, the bug maybe should be closed as INCOMPLETE.

For more information, please visit auto_nag documentation.

Comment 6

[:Gijs (he/him)]

From JIRA:

If closing the tabs will close the window...we should warn users

Comment 7

[:Gijs (he/him)]

I'm pretty lost because this seems to WFM. And I can't even reproduce with a build significantly older than comment 6.

Alice, please reopen with more details if you're still seeing this.