Closed Bug 1575638 Opened 5 months ago Closed 3 months ago

Perform hard-right panning on macbooks in Gecko and not in cubeb

Categories

(Core :: Audio/Video: cubeb, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(2 files)

This is being removed from cubeb in https://github.com/kinetiknz/cubeb/pull/532.

This will also solve bug 1574284.

Blocks: 1574284

Bug 1575131 (which we want to delay until 71) makes landing this a pain, sorry. We can temporarily revert it upstream if you prefer, but it might be good to add a local Gecko patch to update.sh that #ifdefs the initialize_iaudioclient3 call out, making it easier to test that change locally in the meantime.

(In reply to Matthew Gregan [:kinetik] from comment #2)

Bug 1575131 (which we want to delay until 71) makes landing this a pain, sorry. We can temporarily revert it upstream if you prefer, but it might be good to add a local Gecko patch to update.sh that #ifdefs the initialize_iaudioclient3 call out, making it easier to test that change locally in the meantime.

No problem, I'll sort something out with a local patch right now, it's just a matter of a couple of weeks anyways.

Assignee: nobody → padenot
Priority: -- → P2
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bab9dd2438e9
Perform the hard-right panning on macbook pros in Gecko and not in cubeb. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/2097a722000f
Determine whether or not hard panning should be performed on OSX outside the audio callback. r=kinetik
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.