Open Bug 1575639 Opened 5 years ago Updated 1 year ago

Convert most source-related positions to be SourceActor locations instead of Source locations

Categories

(DevTools :: Debugger, task, P3)

task

Tracking

(Not tracked)

People

(Reporter: loganfsmyth, Unassigned)

References

(Depends on 1 open bug)

Details

Right now all of our locations are in the form

type SourceLocation = {
  sourceId: SourceId,
  line: number,
  column: number,
};

which is somewhat at odds with what we want in many cases, because we'd like this data to be associated with a specific SourceActorId instead. For instance, the sourceMap worker currently uses the SourceId as the primary key for a generated source instead of the SourceActorId purely because so much of our code references Source-specific locations.

We should try to migrate most of our source-code-related processing to use locations for specific actors. We'll still also want SourceLocation alongside SourceActorLocation, but it would be used for a much smaller subset of places.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.