Move Firefox wordmark to browser/branding
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: k88hudson, Assigned: emcminn)
References
Details
Attachments
(1 file)
The wordmark/logo that shows up on the new tab page when only search is enabled currently lives in browser/components/newtab/data/content/assets/firefox-wordmark.svg; we should move it to browser/branding.
|
Reporter | |
Updated•5 years ago
|
|
||
Comment 1•5 years ago
|
||
Probably land bug 1574995 first then move the updated file to the correct location?
|
Assignee | |
Comment 2•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Comment 3•5 years ago
|
||
K8, is this something you/Emily are rocking out this iteration?
|
|
Reporter | |
Comment 4•5 years ago
|
||
Yep, just adding a second reviewer on this. Thanks!
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Comment 5•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:emcminn, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
||
Comment 6•5 years ago
|
||
Mardak - can you help this get some eyeballs on it? There's a r+ patch which didn't land and no activity in this bug for 2 weeks. And Kate's NI has been here for a bit. It's not urgent, but would be good to wrap up.
|
|
Reporter | |
Comment 7•5 years ago
|
||
Hey Jess, I was waiting for Bug 1582879 (which is now landed)
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Comment 8•5 years ago
|
||
The patch is close to landing but there was a slight bitrot since it was last touched in october. Looks like emily is assigned and can commandeer the revision to update and land.
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 9•5 years ago
|
||
(In reply to Ed Lee :Mardak from comment #8)
The patch is close to landing but there was a slight bitrot since it was last touched in october. Looks like emily is assigned and can commandeer the revision to update and land.
Hi Ed, is there anything that needs to be done here besides updating/rebasing the patch? I think your last requested change has been taken care of; I don't see a reference to firefox-wordmark.svg in tools/lint/license.yml.
|
|
Assignee | |
Updated•5 years ago
|
|
|
||
Comment 10•5 years ago
|
||
Where are you checking tools/lint/license.yml? The latest change I see is the one that added the entry:
$ git log autoland tools/lint/license.yml
* d13aee4004c36 - Bug 1596911 - refresh the ignore list with the new exts r=Gijs (13 days ago) <Sylvestre Ledru>
https://hg.mozilla.org/mozilla-central/log/tip/tools/lint/license.yml
|
|
Assignee | |
Comment 11•5 years ago
•
|
||
(In reply to Ed Lee :Mardak from comment #10)
Where are you checking
tools/lint/license.yml? The latest change I see is the one that added the entry:$ git log autoland tools/lint/license.yml * d13aee4004c36 - Bug 1596911 - refresh the ignore list with the new exts r=Gijs (13 days ago) <Sylvestre Ledru>https://hg.mozilla.org/mozilla-central/log/tip/tools/lint/license.yml
Ah I see it now, I was looking at the wrong diff. My bad!
EDIT: Updated the diff and fixed license.yml, should be good to go :)
|
|
||
Comment 12•5 years ago
|
||
Hey Emily - what's the next steps to wrap this up? Are you working on it more in this iteration (73.2)?
|
||
Comment 13•5 years ago
|
||
|
|
Assignee | |
Comment 14•5 years ago
|
||
This should be all done, it just needed to be rebased because it had been stale for a while. I'm not able to land patches yet, but if someone else would like to do it it should be good to go :)
|
||
Comment 15•5 years ago
|
||
| bugherder | ||
Description
•