Closed Bug 1575692 Opened 4 years ago Closed 4 years ago

Storage gtest invokes the directory service off the mainthread (via DatabaseLocker::Run() and getDatabase())

Categories

(Toolkit :: Storage, defect)

Product:
Toolkit
Component:
Storage
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

Bug 1575692 - do not recreate the DB file via the directory service inside DatabaseLocker class off the mainthread, r?Standard8
47 bytes, text/x-phabricator-request
Details | Review 
[task 2019-08-21T22:00:28.618Z] 22:00:28     INFO -  TEST-START | storage_unlock_notify.Test
[task 2019-08-21T22:00:28.640Z] 22:00:28     INFO -  Assertion failure: NS_IsMainThread(), at z:/build/build/src/xpcom/io/nsDirectoryService.cpp:186
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #01: getDatabase() [storage/test/gtest/storage_test_harness.h:63]
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #02: DatabaseLocker::Run() [storage/test/gtest/test_unlock_notify.cpp:47]
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #03: nsThread::ProcessNextEvent(bool,bool *) [xpcom/threads/nsThread.cpp:1214]
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #04: NS_ProcessNextEvent(nsIThread *,bool) [xpcom/threads/nsThreadUtils.cpp:486]
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #05: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate *) [ipc/glue/MessagePump.cpp:303]
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #06: MessageLoop::RunHandler() [ipc/chromium/src/base/message_loop.cc:309]
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #07: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2019-08-21T22:00:48.843Z] 22:00:48     INFO -  #08: nsThread::ThreadFunc(void *) [xpcom/threads/nsThread.cpp:460]
[task 2019-08-21T22:00:49.256Z] 22:00:49     INFO -  #09: PR_NativeRunThread [nsprpub/pr/src/threads/combined/pruthr.c:406]

This looks like a testing artifact that should be easy to fix.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0a32477c7afc
do not recreate the DB file via the directory service inside DatabaseLocker class off the mainthread, r=mak

https://hg.mozilla.org/mozilla-central/rev/0a32477c7afc

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.