1575777 - Linting bustage on 2019-08-22

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Looks like M-C landed some changes to their linting rules, so now we see a whole heap of new errors.

Comment 1

[Geoff Lankow (:darktrojan)]

Oh fun.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1575777-no-useless-catch.patch

I did some easy bits. Just ignore if you've done it already. (Can't see you on IRC.)

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 2c6fdd0c3c875b576128c1e4aee2d6dc47387a99

Geoff's work from his try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2c6fdd0c3c875b576128c1e4aee2d6dc47387a99

I looked through it, no functional changes apart from changing an array to an object in am-offline.js which looks right.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e134101a4ca9
Fix various issues after linting changes in M-C. rs=bustage-fix, r=jorgk DONTBUILD

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9087337 [details] [diff] [review]
2c6fdd0c3c875b576128c1e4aee2d6dc47387a99

Paul, can you please check the Calendar bits (or the whole thing if you want).

Comment 6

[Paul Morris [:pmorris]]

Comment on attachment 9087337 [details] [diff] [review]
2c6fdd0c3c875b576128c1e4aee2d6dc47387a99

Review of attachment 9087337 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for the calendar parts.