Closed Bug 1575777 Opened 2 years ago Closed 2 years ago

Linting bustage on 2019-08-22

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: jorgk-bmo, Assigned: darktrojan)

Details

Attachments

(1 file, 1 obsolete file)

Looks like M-C landed some changes to their linting rules, so now we see a whole heap of new errors.

Flags: needinfo?(geoff)

Oh fun.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
Attached patch 1575777-no-useless-catch.patch (obsolete) — Splinter Review

I did some easy bits. Just ignore if you've done it already. (Can't see you on IRC.)

Attachment #9087323 - Flags: review?(geoff)

Geoff's work from his try run:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2c6fdd0c3c875b576128c1e4aee2d6dc47387a99

I looked through it, no functional changes apart from changing an array to an object in am-offline.js which looks right.

Attachment #9087323 - Attachment is obsolete: true
Attachment #9087323 - Flags: review?(geoff)
Attachment #9087337 - Flags: review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e134101a4ca9
Fix various issues after linting changes in M-C. rs=bustage-fix, r=jorgk DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Comment on attachment 9087337 [details] [diff] [review]
2c6fdd0c3c875b576128c1e4aee2d6dc47387a99

Paul, can you please check the Calendar bits (or the whole thing if you want).
Attachment #9087337 - Flags: review?(paul)
Target Milestone: --- → Thunderbird 70.0
Comment on attachment 9087337 [details] [diff] [review]
2c6fdd0c3c875b576128c1e4aee2d6dc47387a99

Review of attachment 9087337 [details] [diff] [review]:
-----------------------------------------------------------------

r+ for the calendar parts.
Attachment #9087337 - Flags: review?(paul) → review+
You need to log in before you can comment on or make changes to this bug.