1575781 - Linux builds busted on 2019-08-22: make[4]: *** [libxul.so] Error 1

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Jorg K (CEST = GMT+2)]

Looking at https://taskcluster-artifacts.net/HoNWkc6fQsuVgw-ynMDeVA/0/public/logs/live_backing.log this seems to be a code issue:

[task 2019-08-22T08:47:31.993Z] 08:47:31 INFO - /builds/worker/fetches/binutils/bin/ld: ../../../comm/mailnews/build/nsMailModule.o: in function nsMessengerUnixIntegrationConstructor(nsISupports*, nsID const&, void**)': [task 2019-08-22T08:47:31.993Z] 08:47:31 INFO - /builds/worker/workspace/build/src/comm/mailnews/build/nsMailModule.cpp:374: undefined reference tonsMessengerUnixIntegration::nsMessengerUnixIntegration()'
[task 2019-08-22T08:47:31.993Z] 08:47:31 INFO - /builds/worker/fetches/binutils/bin/ld: libxul.so: hidden symbol `_ZN26nsMessengerUnixIntegrationC1Ev' isn't defined
[task 2019-08-22T08:47:31.993Z] 08:47:31 INFO - /builds/worker/fetches/binutils/bin/ld: final link failed: bad value
[task 2019-08-22T08:47:31.993Z] 08:47:31 INFO - clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2019-08-22T08:47:31.993Z] 08:47:31 INFO - /builds/worker/workspace/build/src/config/rules.mk:659: recipe for target 'libxul.so' failed
[task 2019-08-22T08:47:31.993Z] 08:47:31 ERROR - make[4]: *** [libxul.so] Error 1

I'll take a look, but maybe something for our Linux guys.

Comment 1

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=835d0d9cdae81b3ab583d4ccf7459d00b041fad6&tochange=efe4a620841ca7032485544176fb051a642c01bc

Maybe this:
https://hg.mozilla.org/mozilla-central/rev/51bf6a97396d96ddb82fa91c2cf9bd9f5bc9ae06

We have that here: https://searchfox.org/comm-central/rev/3d360e890307be83b936f8604a80744bde81387e/mail/components/shell/moz.build#30
I'll do a try run.

Comment 2

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8c95b5467f05265f4ae8dd221ddf7514d1c71422

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: Linux bustage fix

Comment 4

[Jorg K (CEST = GMT+2)]

That didn't help although it appears to be right, hmm.

Comment 5

[Richard Marti (:Paenglab)]

Couldn't it be busted from bug 1573566?

Comment 6

[Jorg K (CEST = GMT+2)]

That landed on 2019-08-17. I think bug 1575420 needs porting and apparently some other stuff.

Comment 7

[Jorg K (CEST = GMT+2)]

I see it now, there's more s/gtk3/gtk/ to do:
https://searchfox.org/comm-central/search?q=GTK3&case=false&regexp=false&path=

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1575781-linux-gtk.patch

Let's see:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=df093081a5e547db9b5fc7796b7ae9febfca5891

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 9087360 [details] [diff] [review]
1575781-linux-gtk.patch

That worked, I'll take review from anyone ;-)

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9087360 [details] [diff] [review]
1575781-linux-gtk.patch

Review of attachment 9087360 [details] [diff] [review]:
-----------------------------------------------------------------

Great! r=mkmelin

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b1270a5cecb
Port bug 1575420: Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=mkmelin