1575785 - There should be a confirmation prompt when the user tries to Report a Broken site from the Tracking Protection panel

Status: VERIFIED FIXED

(Firefox :: Protections UI, enhancement, P3)

Description

[Rares Doghi, Desktop QA]

[Affected versions]:
Nightly 70.0a1

[Affected platforms]:
Platforms: All

Steps :

1. Launch the Firefox browser and reach www.reddit.com
2. Click on the Shield Icon from the URL bar.
3. Click the "Site not Working?" link.
4. Click on the "Send a report" link from the sub panel.
5. Write any text in the text-area and click Send Report.

Expected Results :
A Confirmation prompt, or a Pop-up bubble or any type of confirmation should be displayed when the user clicks the Send report button.
"Your report has been sent", "Thank you for your Report" any message will do.

It could also be something like changing the "Send Report" button to a grey/disabled state without closing the panel, but it would still confuse the user without a confirmation message.

Actual Results :
The panel closes without confirmation, it might push the user to send the same report multiple times thinking he might have clicked outside of the box.

Comment 1

[Johann Hofmann [:johannh]]

To be clear this isn't in the design spec but it's a nice suggestion, thanks. I'll add it to the triage...

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Johann, is this still something you might want to aim at 70/skyline? Might be better to make a p2 and add it for 71 enhancements.

Comment 3

[Johann Hofmann [:johannh]]

We'll take a look...

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1575785 - Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11

Depends on D51382

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4905af6536bd
Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d08754485c25
Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11

Comment 7

[Stefan Hindli [:stefan_hindli]]

Backed out 3 changesets (Bug 1582751, Bug 1575785, Bug 1592616) for causing perma failures in browser/base/content/test/siteProtections/browser_protections_UI.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=193b7b5a17a8e23749e61f3fcef39bcbe921c8e6&selectedJob=274264361

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274264361&repo=autoland&lineNumber=3463

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f243fa3ab1e
Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11

Comment 9

[Cristian Brindusan [:cbrindusan]]

Backed out 4 changesets (Bug 1582751, Bug 1575785, Bug 1592616) for bc failures at browser_protections_UI.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/8da66de59b68180d2676d6609c31ec0d5ded1893

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=274736813&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=7065a97d62f2e7d8981b181be85257f3c50db287

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274736813&repo=autoland&lineNumber=3182

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dde543f12c83
Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c00153e7458
Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8792937b0a60
Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8792937b0a60

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 15

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest nightly build 72.0a1 (2019-11-27), Turned out better than what I had in mind :)