Closed Bug 1575822 Opened 4 years ago Closed 4 years ago

Rename #urlbar-display-box and friends and consolidate related styling

Categories

(Firefox :: Theme, task, P1)

Product:
Firefox
Component:
Theme
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Bug 1575822 - Rename #urlbar-display-box and friends and consolidate related styling. r=ntim
47 bytes, text/x-phabricator-request
Details | Review

The id urlbar-display-box has bothered me for some time, as "display" is pretty meaningless; every GUI element "displays" something. I propose we change this to urlbar-label-box, which is still ambiguous but at least a bit clearer.

We should also rename the switchtab and extension ids because they're not specific enough.

Last but not least, there's some more room for consolidating styles and sharing them across platforms.

Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78fe0feeb890
Rename #urlbar-display-box and friends and consolidate related styling. r=ntim

https://hg.mozilla.org/mozilla-central/rev/78fe0feeb890

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Regressions: 1577318
Iteration: --- → 70.4 - Aug 19 - Sep 1
Points: --- → 3
You need to log in before you can comment on or make changes to this bug.