1575830 - Update how Page / Frame / Image info works

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, task)

Description

[Ian Neal]

Port the following:

• Bug 1238180 - Avoid unsafe CPOWs when opening Page / Frame / Image Info from the context menu
• Bug 1237025 - Stop using CPOWs for View Image Info context menu
• Bug 1241892 - Make Page Info work for sidebar browser

Comment 1

[Ian Neal]

Attachment: Update how page / frame / image info works

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Nothing
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Ian Neal]

Attachment: Update how page / frame / image info works v1.1

Remove unused variable whilst we're at it.

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9087957 [details] [diff] [review]
Update how page / frame / image info works v1.1

lgtm r/a+

 While this is mostly e10s stuff which SM currently does not use it is needed for future backports.

"https://bugzilla.mozilla.org/show_bug.cgi?id=1238180");
NIT shouldn't we change the bug number to this one?

Comment 4

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9087957 [details] [diff] [review]
Update how page / frame / image info works v1.1

lgtm r/a+

While this is mostly e10s stuff which SM currently does not use it is
needed for future backports.

"https://bugzilla.mozilla.org/show_bug.cgi?id=1238180");
NIT shouldn't we change the bug number to this one?

Yes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0c994568bb4a
Update how Page / Frame / Image info works. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/64d0618c8173ff3db9a5263b940d3df25aec594d

Comment 7

[Frank-Rainer Grahl (:frg)]

Fixed 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/2781c2cbd393c79b921780e06323a3934335c648