Closed Bug 1575830 Opened 1 year ago Closed 5 months ago

Update how Page / Frame / Image info works

Categories

(SeaMonkey :: Page Info, task)

task
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.68
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 1 obsolete file)

Port the following:

  • Bug 1238180 - Avoid unsafe CPOWs when opening Page / Frame / Image Info from the context menu
  • Bug 1237025 - Stop using CPOWs for View Image Info context menu
  • Bug 1241892 - Make Page Info work for sidebar browser

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Nothing
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Attachment #9087702 - Flags: review?(frgrahl)
Attachment #9087702 - Flags: approval-comm-release?
Attachment #9087702 - Flags: approval-comm-esr60?

Remove unused variable whilst we're at it.

Attachment #9087702 - Attachment is obsolete: true
Attachment #9087702 - Flags: review?(frgrahl)
Attachment #9087702 - Flags: approval-comm-release?
Attachment #9087702 - Flags: approval-comm-esr60?
Attachment #9087957 - Flags: review?(frgrahl)
Attachment #9087957 - Flags: approval-comm-release?
Attachment #9087957 - Flags: approval-comm-esr60?
Blocks: 1578061
Comment on attachment 9087957 [details] [diff] [review]
Update how page / frame / image info works v1.1

lgtm r/a+

 While this is mostly e10s stuff which SM currently does not use it is needed for future backports.

"https://bugzilla.mozilla.org/show_bug.cgi?id=1238180");
NIT shouldn't we change the bug number to this one?
Attachment #9087957 - Flags: review?(frgrahl)
Attachment #9087957 - Flags: review+
Attachment #9087957 - Flags: approval-comm-release?
Attachment #9087957 - Flags: approval-comm-release+
Attachment #9087957 - Flags: approval-comm-esr60?
Attachment #9087957 - Flags: approval-comm-esr60+

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9087957 [details] [diff] [review]
Update how page / frame / image info works v1.1

lgtm r/a+

While this is mostly e10s stuff which SM currently does not use it is
needed for future backports.

"https://bugzilla.mozilla.org/show_bug.cgi?id=1238180");
NIT shouldn't we change the bug number to this one?

Yes.

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0c994568bb4a
Update how Page / Frame / Image info works. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.68
You need to log in before you can comment on or make changes to this bug.