Closed Bug 1575847 Opened 4 months ago Closed 4 months ago

Profiler_get_backtrace can do a racy check to see if the profiler is active

Categories

(Core :: Gecko Profiler, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bas.schouten, Assigned: bas.schouten)

Details

Attachments

(1 file)

This would mean not all callers have to wrap it in profiler_is_active, which is racy anyway. Markus believes this is harmless and it would prevent us from grabbing the lock when the profiler isn't running.

Good idea, thank you.

Priority: -- → P2
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3e16ace8b640
Do a racy early return from profiler_get_backtrace if the profiler isn't active. r=mstange
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.