1575870 - Remove support for XLink on MathML elements

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang (:fredw)]

This would at least save some code.

We have been sending deprecation warning for 7 years (bug 553917)

For details and discussion I opened https://github.com/mathml-refresh/mathml/issues/127

Comment 1

[Frédéric Wang (:fredw)]

There are more XLink attributes: “href”, “type”, “show” and “actuate”
I think we can try to deprecated all of them on MathML elements.

Comment 2

[Frédéric Wang (:fredw)]

Attachment: data-collection-mathml-xlink-attributes.txt

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Bug 1575870. Remove support for XLink on MathML elements. r=emilio

WIP

Comment 4

[Ben Miroglio [:bmiroglio]]

Comment on attachment 9087924 [details]
data-collection-mathml-xlink-attributes.txt

# Data Review Form

1) Is there or will there be **documentation** that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, this will be documented in the probe dictionary: https://telemetry.mozilla.org/probe-dictionary/

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, this can be turned off in Preferences, by disabling Telemetry.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

This is not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1: Technical Data

5) Is the data collection request for default-on or default-off?

default-on

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No

7) Is the data collection covered by the existing Firefox privacy notice? **If unsure: escalate to legal if:**

Yes

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Yes, in ~4 release cycles, we should check in and assess a renewal.

9) Does the data collection use a third-party collection tool? **If yes, escalate to legal.**

No

data-review r+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f20ce5c7a25c
Remove support for XLink on MathML elements. r=emilio

Comment 6

[Andreea Pavel [:apavel]]

Backed out for assertion failure at nsNavHistory

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=f20ce5c7a25c435989764808918e08e62ebada4e&selectedJob=264020217

Tier1 failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264023124&repo=autoland&lineNumber=5267

[task 2019-08-29T10:30:53.139Z] 10:30:53 INFO - TEST-START | browser/base/content/test/general/browser_contentAltClick.js
[task 2019-08-29T10:30:53.157Z] 10:30:53 INFO - GECKO(1080) | ++DOCSHELL 0x7f587d08a800 == 2 [pid = 1278] [id = {d710206e-fa9f-4dcb-a003-d96e8d7be63c}]
[task 2019-08-29T10:30:53.158Z] 10:30:53 INFO - GECKO(1080) | ++DOMWINDOW == 7 (0x7f587bd502e0) [pid = 1278] [serial = 177] [outer = (nil)]
[task 2019-08-29T10:30:53.158Z] 10:30:53 INFO - GECKO(1080) | ++DOMWINDOW == 8 (0x7f587bd92800) [pid = 1278] [serial = 178] [outer = 0x7f587bd502e0]
[task 2019-08-29T10:30:53.206Z] 10:30:53 INFO - GECKO(1080) | ++DOMWINDOW == 9 (0x7f587d09b400) [pid = 1278] [serial = 179] [outer = 0x7f587bd502e0]
[task 2019-08-29T10:30:53.214Z] 10:30:53 INFO - GECKO(1080) | [Child 1278, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, this) failed with result 0x80004005: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 489
[task 2019-08-29T10:30:53.493Z] 10:30:53 INFO - GECKO(1080) | --DOMWINDOW == 14 (0x7fcb53893400) [pid = 1249] [serial = 96] [outer = (nil)] [url = about:blank]
[task 2019-08-29T10:30:53.494Z] 10:30:53 INFO - GECKO(1080) | --DOMWINDOW == 13 (0x7fcb5389d400) [pid = 1249] [serial = 99] [outer = (nil)] [url = http://mochi.test:8888/browser/]
[task 2019-08-29T10:30:53.494Z] 10:30:53 INFO - GECKO(1080) | --DOMWINDOW == 12 (0x7fcb5369f800) [pid = 1249] [serial = 93] [outer = (nil)] [url = http://mochi.test:8888/browser/]
[task 2019-08-29T10:30:53.495Z] 10:30:53 INFO - GECKO(1080) | --DOMWINDOW == 11 (0x7fcb51d0d400) [pid = 1249] [serial = 90] [outer = (nil)] [url = about:blank]
[task 2019-08-29T10:30:53.495Z] 10:30:53 INFO - GECKO(1080) | --DOMWINDOW == 10 (0x7fcb55d45400) [pid = 1249] [serial = 102] [outer = (nil)] [url = about:blank]
[task 2019-08-29T10:30:53.495Z] 10:30:53 INFO - GECKO(1080) | --DOCSHELL 0x7fcb51dba800 == 2 [pid = 1249] [id = {219dc1f2-0832-4646-a457-ec56246dd674}] [url = http://mochi.test:8888/browser/browser/base/content/test/general/browser_bug970746.xhtml]
[task 2019-08-29T10:30:53.495Z] 10:30:53 INFO - GECKO(1080) | --DOCSHELL 0x7fcb53807000 == 1 [pid = 1249] [id = {a3275c8b-a066-4036-8fd5-de9e3eacea92}] [url = about:blank]
[task 2019-08-29T10:30:53.571Z] 10:30:53 INFO - GECKO(1080) | --DOMWINDOW == 9 (0x7fcb53678d40) [pid = 1249] [serial = 103] [outer = (nil)] [url = about:blank]
[task 2019-08-29T10:30:53.881Z] 10:30:53 INFO - GECKO(1080) | [Parent 1080, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x7f4e53e2e420 (http://mzl.la/1FuID0j).: file /builds/worker/workspace/build/src/storage/mozStoragePrivateHelpers.cpp, line 108
[task 2019-08-29T10:30:53.917Z] 10:30:53 INFO - GECKO(1080) | ++DOCSHELL 0x7fcb51db8000 == 2 [pid = 1249] [id = {8853675a-d509-4ca5-86b2-ccbbdf17fa89}]
[task 2019-08-29T10:30:53.919Z] 10:30:53 INFO - GECKO(1080) | ++DOMWINDOW == 10 (0x7fcb51de25c0) [pid = 1249] [serial = 113] [outer = (nil)]
[task 2019-08-29T10:30:53.921Z] 10:30:53 INFO - GECKO(1080) | ++DOMWINDOW == 11 (0x7fcb51d0e400) [pid = 1249] [serial = 114] [outer = 0x7fcb51de25c0]
[task 2019-08-29T10:30:53.977Z] 10:30:53 INFO - GECKO(1080) | ++DOMWINDOW == 12 (0x7fcb53890c00) [pid = 1249] [serial = 115] [outer = 0x7fcb51de25c0]
[task 2019-08-29T10:30:53.985Z] 10:30:53 INFO - GECKO(1080) | [Child 1249, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, this) failed with result 0x80004005: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 489
[task 2019-08-29T10:30:54.369Z] 10:30:54 INFO - GECKO(1080) | [Parent 1080, Main Thread] WARNING: Suboptimal indexes for the SQL statement 0x7f4e53e2e420 (http://mzl.la/1FuID0j).: file /builds/worker/workspace/build/src/storage/mozStoragePrivateHelpers.cpp, line 108
[task 2019-08-29T10:30:54.413Z] 10:30:54 INFO - GECKO(1080) | ++DOCSHELL 0x7f587f414800 == 3 [pid = 1278] [id = {7dd9266a-65bb-4264-9820-0de0e546fd9c}]
[task 2019-08-29T10:30:54.414Z] 10:30:54 INFO - GECKO(1080) | ++DOMWINDOW == 10 (0x7f587bd504c0) [pid = 1278] [serial = 180] [outer = (nil)]
[task 2019-08-29T10:30:54.414Z] 10:30:54 INFO - GECKO(1080) | ++DOMWINDOW == 11 (0x7f587bdf5400) [pid = 1278] [serial = 181] [outer = 0x7f587bd504c0]
[task 2019-08-29T10:30:54.457Z] 10:30:54 INFO - GECKO(1080) | ++DOMWINDOW == 12 (0x7f587f781c00) [pid = 1278] [serial = 182] [outer = 0x7f587bd504c0]
[task 2019-08-29T10:30:54.473Z] 10:30:54 INFO - GECKO(1080) | [Child 1278, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, this) failed with result 0x80004005: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 489
[task 2019-08-29T10:30:54.911Z] 10:30:54 INFO - GECKO(1080) | Assertion failure: false (MOZ_ASSERT_UNREACHABLE: Trying to get a result node for an invalid visit), at /builds/worker/workspace/build/src/toolkit/components/places/nsNavHistory.cpp:3190
[task 2019-08-29T10:30:54.912Z] 10:30:54 INFO - GECKO(1080) | #01: nsNavHistoryQueryResultNode::OnVisit(nsIURI, long, long, unsigned int, bool, unsigned int) [toolkit/components/places/nsNavHistoryResult.cpp:2090]
[task 2019-08-29T10:30:54.912Z] 10:30:54 INFO -
[task 2019-08-29T10:30:54.913Z] 10:30:54 INFO - GECKO(1080) | #02: nsNavHistoryResult::OnVisit(nsIURI, long, long, unsigned int, nsTSubstring<char> const&, bool, unsigned int, nsTSubstring<char16_t> const&) [toolkit/components/places/nsNavHistoryResult.cpp:3997]
[task 2019-08-29T10:30:54.913Z] 10:30:54 INFO -
[task 2019-08-29T10:30:54.913Z] 10:30:54 INFO - GECKO(1080) | #03: nsNavHistoryResult::HandlePlacesEvent(mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::dom::PlacesEvent> > const&) [toolkit/components/places/nsNavHistoryResult.cpp:4086]

Backout: https://hg.mozilla.org/integration/autoland/rev/67f3cd7e58ca8aadcddaf11b00a6aeedf4113727

Comment 7

[Frédéric Wang (:fredw)]

I'll take a look into this later.

Comment 8

[Frédéric Wang (:fredw)]

IIUC, browser_contentAltClick.js forces alt+click to perform a save operation so it does not seem appropriate to do it with non-link nodes. But thinking more about it, I think we should just update the tests to use normal MathML link instead of XLink.

Comment 9

[Frédéric Wang (:fredw)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a46585fdd7a22bd64f3511eaaa3aa0aaea0d7424

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93aec03cc202
Remove support for XLink on MathML elements. r=emilio

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/93aec03cc202

Comment 12

[Kohei Yoshino]

Posted site compatibility note: https://www.fxsitecompat.dev/en-CA/docs/2019/various-legacy-mathml-features-have-been-deprecated/

Comment 13

[Florian Scholz (Open Web Docs)]

Added the deprecation to https://developer.mozilla.org/en-US/docs/Web/MathML/Attribute.
I don't think we've documented this anywhere properly.

Please add 'dev-doc-needed' to the bug that removes this in a stable Firefox version so that we can mention this in release notes then.