Closed Bug 1575887 Opened 2 months ago Closed 2 months ago

The "CFR Pin Tabs" recommendations are no longer displayed

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 + verified
firefox70 + verified

People

(Reporter: mcoman, Assigned: andreio)

References

(Regression)

Details

(Keywords: github-merged, regression)

Attachments

(3 files)

[Affected versions]:

  • Firefox Beta 69.0b15 - Build ID: 20190819184224
  • Firefox Nightly 70.0a1 - Build ID: 20190822095439

[Affected Platforms]:

  • All Windows
  • All Linux
  • All Mac

[Prerequisites]:

  • Have a new Firefox profile,
  • Have no other tab already pinned.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Open a new tab and navigate to "https://www.youtube.com/"
  3. Change the system's time to 17 min into the future.
  4. Repeat step 2 and 3 again.
  5. Open a new tab and navigate to "https://www.youtube.com/".
  6. Observe the right part of the "Adress Bar".

[Expected result]:

  • The "CFR Recommendation" button is displayed in the right part of the "Address Bar".

[Actual result]:

  • Only the "Page actions", "Save to Pocket" and "Bookmark this page" buttons are displayed.

[Regression Window]:

[Notes]:

  • Attached a screen recording of the issue.

Ed, could you please take a look over this issue?

Flags: needinfo?(edilee)
Assignee: nobody → andrei.br92
Flags: needinfo?(edilee)
Iteration: --- → 70.4 - Aug 19 - Sep 1
Priority: -- → P1
Regressed by: 1561536
Blocks: 1576284

[Tracking Requested - why for this release]: This CFR Pin Tab regression affects 69 as it was uplifted as part of https://hg.mozilla.org/releases/mozilla-beta/rev/feeaf170fca669a675eff2cb16bd56b0a329b508

This regression is similar to the plain CFR regression bug 1571818 that was noticed, fixed, uplifted to 69 (as part of the above revision).

Status: NEW → RESOLVED
Closed: 2 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (70.0a1 Build ID - 20190825213650) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5.

Status: RESOLVED → VERIFIED
Summary: The "CRF Pin Tabs" recommendations are no longer displayed → The "CFR Pin Tabs" recommendations are no longer displayed

Comment on attachment 9088153 [details]
Bug 1575887 - The CRF Pin Tabs recommendations are no longer displayed

Beta/Release Uplift Approval Request

  • User impact if declined: Regresses the CFR pin tab message
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: already tested
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small patch. Changes have been verified.
  • String changes made/needed:
Attachment #9088153 - Flags: approval-mozilla-beta?

Comment on attachment 9088153 [details]
Bug 1575887 - The CRF Pin Tabs recommendations are no longer displayed

Fixes a regression in the CFR relationship scoping work shipping in Fx69. Approved for 69.0rc1.

Attachment #9088153 - Flags: approval-mozilla-beta? → approval-mozilla-release+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

I have verified that this issue is no longer reproducible with the latest Firefox 69.0 rc2 (Build ID - 20190827005903) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the "CFR Pin Tabs" recommendations are successfully displayed.

Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.