1575905 - Surface enable/disable actions in Themes Manager

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Amy Tsay [:amyt]]

The enable/disable actions are currently in the meatball menu of the themes list view. We would like to surface them one level higher so users can enable and disable themes without having to click into the meatball menu.

Comment 1

[Amy Tsay [:amyt]]

Per 9/26/19 meeting:

• Change "Enabled" section header to "Your Active Theme"
• Change "Disabled" section header to "Other Installed Themes"
• Add "Disable" button to the current theme
• Add "Enable" button to themes listed under "Your Themes"
• Meatball menu options should be "Remove" and "Manage"
• Add theme skeleton to the 3 default themes

Emanuela to attach sketches, Jeff to review proposed copy changes above.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Can we consider "Your Themes" instead of "Your Theme Collection"? The term "collection" can be confused with the AMO feature.

Comment 3

[Amy Tsay [:amyt]]

Yep, edited comment 1 with the update.

Comment 4

[Jeff Pfaller]

For Disabled Themes, can we do "Installed Themes"

Comment 5

[Amy Tsay [:amyt]]

How about "Your Active Theme" for the current theme, and "Other Installed Themes" for the disabled themes?

Comment 6

[Jeff Pfaller]

I'm fine with that!

Comment 7

[emanuela [ux]]

Attachment: dark-theme.svg

Skeleton Dark Theme

Comment 8

[emanuela [ux]]

Attachment: light-theme.svg

Skeleton light theme

Comment 9

[emanuela [ux]]

Attachment: default-theme.svg

Skeleton default theme

Comment 10

[emanuela [ux]]

Attachment: themes-ui-2019.jpg

Reference mock.

Not included in the mock but included in the actual page is the section Recommended Themes below Other Installed Themes.

Comment 11

[Mark Striemer [:mstriemer]]

Attachment: Bug 1575905 - Part 1: Show theme previews for built-in themes, hide theme icons r?rpl

Comment 12

[Mark Striemer [:mstriemer]]

Attachment: Bug 1575905 - Part 2: Surface enable/disable button on theme cards r?rpl

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13d8e61774f1
Part 1: Show theme previews for built-in themes, hide theme icons r=rpl,Gijs
https://hg.mozilla.org/integration/autoland/rev/67f284b0e4c2
Part 2: Surface enable/disable button on theme cards r=rpl,Gijs

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58af480a23ba
Part 1: Show theme previews for built-in themes, hide theme icons r=rpl,Gijs
https://hg.mozilla.org/integration/autoland/rev/2283d57d384b
Part 2: Surface enable/disable button on theme cards r=rpl,Gijs

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/58af480a23ba
https://hg.mozilla.org/mozilla-central/rev/2283d57d384b

Comment 16

[Alex Cornestean]

Attachment: Themes Manager latest Nightly 11.27.2019.png

Hello,

Verified the fix on the latest Nightly (72.0a1/20191126212708) under Windows 10 Pro 64-bit and MacOS Catalina 10.15.

Going over several variants of the layout of the Themes Manager which were proposed throughout the comments in this ticket and the state of the Themes Manager on the latest Nightly, the following were observed:

• in what regards the buttons to enable/disable themes present on the themes cards, these have been detailed in Comment 10 of https://bugzilla.mozilla.org/show_bug.cgi?id=1570792
• the headers proposed for the Enabled and Disabled themes are not present. The old ones are still used.
• built-in themes have previews now

Please see the attached screenshot for further details.

Can you please confirm that these are intended changes before changing the status of the bug? Thank you!

Comment 17

[Mark Striemer [:mstriemer]]

That's correct. I filed bug 1599813 since the headings should've been updated, but I forgot about it.

Comment 18

[Alex Cornestean]

Hello,

I will verify this fix after the dependency (https://bugzilla.mozilla.org/show_bug.cgi?id=1599813) has been fixed and validated.