1575906 - Crash annotations don't work in GeckoMediaPlugin processes on Windows

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P1)

Description

[Jed Davis [:jld] ⟨⏰|UTC-8⟩ ⟦he/him⟧]

I'm not sure what component to file this in, so let's start here. This call in CrashReporterClient::InitSingleton always fails on Windows in GeckoMediaPlugin processes, meaning that the CrashReporterClient is never initialized (this is silently ignored), the CrashReporterHost in the parent process is never constructed, and CrashReporter::AnnotateCrashReport won't work. (I haven't tested that outcome directly, but I'm assuming that that would be the case given what happened in bug 1574571.)

The reason it fails is probably sandboxing: normally the GMP process doesn't create shared memory or (I think?) send handles to another process, so it probably doesn't have the permissions it would need to do that.

STR: apply a patch like this Try run and run any test that uses GMP (like ./mach gtest GeckoMediaPlug\*)

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1575906: Allow the GMP process to duplicate Section handles to the main process. r=handyman!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54dcc1dc10c7
Allow the GMP process to duplicate Section handles to the main process. r=handyman

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/54dcc1dc10c7

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/54dcc1dc10c7

Comment 5

[Bob Owen (:bobowen)]

(In reply to Bogdan Tara[:bogdan_tara] from comment #4)

https://hg.mozilla.org/releases/mozilla-beta/rev/54dcc1dc10c7

This wasn't flagged for uplift, but I think it is unlikely to cause any issues.