Closed Bug 1575906 Opened 3 months ago Closed 3 months ago

Crash annotations don't work in GeckoMediaPlugin processes on Windows

Categories

(Toolkit :: Crash Reporting, defect, P1)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: jld, Assigned: bobowen)

References

Details

Attachments

(1 file)

I'm not sure what component to file this in, so let's start here. This call in CrashReporterClient::InitSingleton always fails on Windows in GeckoMediaPlugin processes, meaning that the CrashReporterClient is never initialized (this is silently ignored), the CrashReporterHost in the parent process is never constructed, and CrashReporter::AnnotateCrashReport won't work. (I haven't tested that outcome directly, but I'm assuming that that would be the case given what happened in bug 1574571.)

The reason it fails is probably sandboxing: normally the GMP process doesn't create shared memory or (I think?) send handles to another process, so it probably doesn't have the permissions it would need to do that.

STR: apply a patch like this Try run and run any test that uses GMP (like ./mach gtest GeckoMediaPlug\*)

Assignee: nobody → bobowencode
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/54dcc1dc10c7
Allow the GMP process to duplicate Section handles to the main process. r=handyman
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

(In reply to Bogdan Tara[:bogdan_tara] from comment #4)

https://hg.mozilla.org/releases/mozilla-beta/rev/54dcc1dc10c7

This wasn't flagged for uplift, but I think it is unlikely to cause any issues.

Blocks: 1578422
You need to log in before you can comment on or make changes to this bug.