Closed Bug 1575913 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18615 - Add parser and evaluation WPT for <length> involving min/max()

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla70

Tracking Flags:

Tracking

Status

firefox70

---

fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Description

•

5 years ago

Sync web-platform-tests PR 18615 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18615
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Add parser and evaluation WPT for <length> involving min/max()

Bug: 978682
Change-Id: I428f84d516cf5ab4df8aa754f406008c034b6e24
Reviewed-on: https://chromium-review.googlesource.com/1764793
WPT-Export-Revision: b3117842f7812cbd36aa9596d4bbf03df29d0216

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

5 years ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

5 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=174882db1b22d49fdb1cb9ac4f9cd3c989d596b0

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

5 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1aded61a775de3255fea65898ebadea537daf8a1

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

5 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=2268d05250208eeffb5c2ef6bd75e017f18df4c8

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 4

•

5 years ago

Ran 2 tests and 128 subtests
OK     : 2
PASS   : 49
FAIL   : 79

New tests that have failures or other problems:
/css/css-values/minmax-length-computed.html
    Property letter-spacing value 'calc(max(1em, 19px) * 2' computes to '40px': FAIL
    Property letter-spacing value 'calc(max(1em, 19px) + 10px)' computes to '30px': FAIL
    Property letter-spacing value 'calc(max(1em, 19px) - 10px)' computes to '10px': FAIL
    Property letter-spacing value 'calc(max(1em, 19px) / 2' computes to '10px': FAIL
    Property letter-spacing value 'calc(min(1em, 21px) * 2' computes to '40px': FAIL
    Property letter-spacing value 'calc(min(1em, 21px) + 10px)' computes to '30px': FAIL
    Property letter-spacing value 'calc(min(1em, 21px) + max(0.9em, 20px))' computes to '40px': FAIL
    Property letter-spacing value 'calc(min(1em, 21px) - 10px)' computes to '10px': FAIL
    Property letter-spacing value 'calc(min(1em, 21px) / 2' computes to '10px': FAIL
    Property letter-spacing value 'max(15px, 1em)' computes to '20px': FAIL
    Property letter-spacing value 'max(15px, 2em)' computes to '20px': FAIL
    Property letter-spacing value 'max(15px, min(25px, 1em))' computes to '20px': FAIL
    Property letter-spacing value 'max(1Q)' computes to '0.944882px': FAIL
    Property letter-spacing value 'max(1Q, 2Q)' computes to '1.88976px': FAIL
    Property letter-spacing value 'max(1ch)' computes to '10px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1ch)' computes to '11.2333px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1ch)' computes to '13px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1ch, 2ch)' computes to '20px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1ch, 2ch)' computes to '22.4667px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1ch, 2ch)' computes to '26px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1cm)' computes to '37.7953px': FAIL
    Property letter-spacing value 'max(1cm, 2cm)' computes to '75.5906px': FAIL
    Property letter-spacing value 'max(1em)' computes to '20px': FAIL
    Property letter-spacing value 'max(1em, 2em)' computes to '40px': FAIL
    Property letter-spacing value 'max(1ex)' computes to '10.5667px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1ex)' computes to '10px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1ex)' computes to '8.95px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1ex, 2ex)' computes to '17.9px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1ex, 2ex)' computes to '20px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1ex, 2ex)' computes to '21.1333px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1in)' computes to '96px': FAIL
    Property letter-spacing value 'max(1in, 2in)' computes to '192px': FAIL
    Property letter-spacing value 'max(1mm)' computes to '3.77953px': FAIL
    Property letter-spacing value 'max(1mm, 2mm)' computes to '7.55906px': FAIL
    Property letter-spacing value 'max(1pc)' computes to '16px': FAIL
    Property letter-spacing value 'max(1pc, 2pc)' computes to '32px': FAIL
    Property letter-spacing value 'max(1pt)' computes to '1.33333px': FAIL
    Property letter-spacing value 'max(1pt, 2pt)' computes to '2.66667px': FAIL
    Property letter-spacing value 'max(1px)' computes to '1px': FAIL
    Property letter-spacing value 'max(1px, 2px)' computes to '2px': FAIL
    Property letter-spacing value 'max(1rem)' computes to '16px': FAIL
    Property letter-spacing value 'max(1rem, 2rem)' computes to '32px': FAIL
    Property letter-spacing value 'max(1vh)' computes to '11.35px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vh)' computes to '9.48333px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1vh)' computes to '9.65px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1vh, 2vh)' computes to '18.9667px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1vh, 2vh)' computes to '19.3167px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1vh, 2vh)' computes to '22.7167px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vmax)' computes to '11.35px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vmax)' computes to '12.8px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1vmax, 2vmax)' computes to '22.7167px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vmax, 2vmax)' computes to '25.6px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1vmin)' computes to '8px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vmin)' computes to '9.48333px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1vmin)' computes to '9.65px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1vmin, 2vmin)' computes to '16px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vmin, 2vmin)' computes to '18.9667px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1vmin, 2vmin)' computes to '19.3167px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'max(1vw)' computes to '12.8px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(1vw)' computes to '8px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vw, 2vw)' computes to '16px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'max(1vw, 2vw)' computes to '25.6px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'max(25px, 1em)' computes to '25px': FAIL
    Property letter-spacing value 'max(95px, 1in)' computes to '96px': FAIL
    Property letter-spacing value 'min(15px, 1em)' computes to '10px': FAIL
    Property letter-spacing value 'min(15px, 1em)' computes to '15px': FAIL
    Property letter-spacing value 'min(1Q)' computes to '0.944882px': FAIL
    Property letter-spacing value 'min(1Q, 2Q)' computes to '0.944882px': FAIL
    Property letter-spacing value 'min(1ch)' computes to '10px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1ch)' computes to '11.2333px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1ch)' computes to '13px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1ch, 2ch)' computes to '10px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1ch, 2ch)' computes to '11.2333px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1ch, 2ch)' computes to '13px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1cm)' computes to '37.7953px': FAIL
    Property letter-spacing value 'min(1cm, 2cm)' computes to '37.7953px': FAIL
    Property letter-spacing value 'min(1em)' computes to '20px': FAIL
    Property letter-spacing value 'min(1em, 2em)' computes to '20px': FAIL
    Property letter-spacing value 'min(1ex)' computes to '10.5667px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1ex)' computes to '10px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1ex)' computes to '8.95px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1ex, 2ex)' computes to '10.5667px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1ex, 2ex)' computes to '10px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1ex, 2ex)' computes to '8.95px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1in)' computes to '96px': FAIL
    Property letter-spacing value 'min(1in, 2in)' computes to '96px': FAIL
    Property letter-spacing value 'min(1mm)' computes to '3.77953px': FAIL
    Property letter-spacing value 'min(1mm, 2mm)' computes to '3.77953px': FAIL
    Property letter-spacing value 'min(1pc)' computes to '16px': FAIL
    Property letter-spacing value 'min(1pc, 2pc)' computes to '16px': FAIL
    Property letter-spacing value 'min(1pt)' computes to '1.33333px': FAIL
    Property letter-spacing value 'min(1pt, 2pt)' computes to '1.33333px': FAIL
    Property letter-spacing value 'min(1px)' computes to '1px': FAIL
    Property letter-spacing value 'min(1px, 2px)' computes to '1px': FAIL
    Property letter-spacing value 'min(1rem)' computes to '16px': FAIL
    Property letter-spacing value 'min(1rem, 2rem)' computes to '16px': FAIL
    Property letter-spacing value 'min(1vh)' computes to '11.35px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1vh)' computes to '9.48333px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vh)' computes to '9.65px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1vh, 2vh)' computes to '11.35px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1vh, 2vh)' computes to '9.48333px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vh, 2vh)' computes to '9.65px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1vmax)' computes to '11.35px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1vmax)' computes to '12.8px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vmax, 2vmax)' computes to '11.35px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1vmax, 2vmax)' computes to '12.8px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vmin)' computes to '8px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1vmin)' computes to '9.48333px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vmin)' computes to '9.65px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1vmin, 2vmin)' computes to '8px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1vmin, 2vmin)' computes to '9.48333px': FAIL[windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vmin, 2vmin)' computes to '9.65px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt]
    Property letter-spacing value 'min(1vw)' computes to '12.8px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vw)' computes to '8px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(1vw, 2vw)' computes to '12.8px': FAIL[linux64-asan-opt,linux64-debug,linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows10-64-qr-opt,windows7-32-debug,windows7-32-opt]
    Property letter-spacing value 'min(1vw, 2vw)' computes to '8px': FAIL[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview]
    Property letter-spacing value 'min(25px, 1em)' computes to '20px': FAIL
    Property letter-spacing value 'min(25px, max(15px, 1em))' computes to '20px': FAIL
    Property letter-spacing value 'min(95px, 1in)' computes to '95px': FAIL

Pulsebot

Comment 5

•

5 years ago

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/972b84000313
[wpt PR 18615] - Add parser and evaluation WPT for <length> involving min/max(), a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/e94004217929
[wpt PR 18615] - Update wpt metadata, a=testonly

Cosmin Sabou [:CosminS]

Comment 6

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/972b84000313
https://hg.mozilla.org/mozilla-central/rev/e94004217929

Status: NEW → RESOLVED

Closed: 5 years ago

status-firefox70: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla70

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Quick Search

[wpt-sync] Sync PR 18615 - Add parser and evaluation WPT for <length> involving min/max()

Categories

(Core :: CSS Parsing and Computation, task, P4)

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

Comment 3

Comment 4

Comment 5

Comment 6