Closed Bug 1575924 Opened 2 years ago Closed 2 years ago

Clean up Resist Fingerprinting code with clang readability checks

Categories

(Core :: DOM: Security, enhancement)

Product:
Core
Component:
DOM: Security
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: tjr, Assigned: tjr)

Details

Attachments

(4 files)

Bug 1575924 - Apply readability-implicit-bool-conversion to Resist Fingerpritning code r?timhuang
47 bytes, text/x-phabricator-request
Details | Review
Bug 1575924 - Apply readability-inconsistent-declaration-parameter-name to Resist Fingerpritning code r?timhuang
47 bytes, text/x-phabricator-request
Details | Review
Bug 1575924 - A couple more clang-tidy checks for Resist Fingerprinting r?timhuang
47 bytes, text/x-phabricator-request
Details | Review
Bug 1575924 - Final clang-tidy checks for Resist Fingerprinting r?timhuang
47 bytes, text/x-phabricator-request
Details | Review

Playing around with clang-tidy....

Deleting a null pointer has no effect. Else after return.

Depends on D43108

Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88adfeed2265
Apply readability-implicit-bool-conversion to Resist Fingerpritning code r=timhuang
https://hg.mozilla.org/integration/autoland/rev/bcf1874cde54
Apply readability-inconsistent-declaration-parameter-name to Resist Fingerpritning code r=timhuang
https://hg.mozilla.org/integration/autoland/rev/79f74b10e771
A couple more clang-tidy checks for Resist Fingerprinting r=timhuang
https://hg.mozilla.org/integration/autoland/rev/a7a5fdf0f2cb
Final clang-tidy checks for Resist Fingerprinting r=timhuang
You need to log in before you can comment on or make changes to this bug.