1575954 - Create React App error causes replay.js error and rewind to fail

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[:Harald Kirschner :digitarald]

STR:

1. Enable Record on https://firefox-debugger-example-create-react-app.glitch.me/
2. Win the game (3 in a row)
3. Set another field
4. React error page is shown

AR: Can't step back anymore
ER: Rewind works

Content console:
NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative

Browser console:

error occurred while processing 'sources': TypeError: this.dbg.findSourceURLs is not a function
Stack: addAllSources@resource://devtools/server/actors/thread.js:1316:32
onSources@resource://devtools/server/actors/thread.js:1339:10
onPacket@resource://devtools/server/debugger-server-connection.js:378:58
receiveMessage@resource://devtools/shared/transport/child-transport.js:66:16
MessageListener.receiveMessage*_addListener@resource://devtools/shared/transport/child-transport.js:40:14
ready@resource://devtools/shared/transport/child-transport.js:57:10
_onConnection@resource://devtools/server/debugger-server.js:491:15
connectToParent@resource://devtools/server/debugger-server.js:349:17
onConnect<@resource://devtools/server/startup/frame.js:62:35
exports.makeInfallible/<@resource://devtools/shared/ThreadSafeDevToolsUtils.js:111:22
MessageListener.receiveMessage*@resource://devtools/server/startup/frame.js:92:23
@resource://devtools/server/startup/frame.js:174:5
Line: 1316, column: 32 debugger-server-connection.js:232
NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative replay.js:261
Error: Assertion Failed! 4 control.js:2016:17

Comment 1

[Jason Laster [:jlast]]

This patch fixes the first bug (https://phabricator.services.mozilla.com/D43103), but does not fix this error:

NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative replay.js:261

Brian, do you know what is happening here?

Comment 2

[Jason Laster [:jlast]]

Attachment: Screen Shot 2019-08-22 at 1.53.24 PM.png

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Bug 1575954 - QI for nsIDocShell before setting watchedByDevtools, r=jlast.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff1dfd35561a
QI for nsIDocShell before setting watchedByDevtools, r=jlast.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ff1dfd35561a