157597 - Make embedding base and examples use XPCOM Glue

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Doug Turner (:dougt)]

Comment 1

[Doug Turner (:dougt)]

.

Comment 2

[Doug Turner (:dougt)]

Attachment: proposed patch v.1

1.  make embedding base use xpcom glue.
2.  cleans up embedding examples to not use nsCRT or nsComponentManager

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v.2

same as above but correctly builds browser/activex/src/control/

Comment 4

[Adam Lock]

Comment on attachment 91660 [details] [diff] [review]
patch v.2

r=adamlock

Comment 5

[rpotts (gone)]

Comment on attachment 91660 [details] [diff] [review]
patch v.2

sr=[e-mail]

i'd change the definitions of strcmp() and strlen() from private static
implementations to inline functions that call lstrcmpW() and lstrlenW()
respectively.

Comment 6

[Scott Collins]

Comment on attachment 91660 [details] [diff] [review]
patch v.2

a=scc for checkin to the mozilla trunk

Comment 7

[Doug Turner (:dougt)]

Fix checked in.

Checking in base/Makefile.in;
/cvsroot/mozilla/embedding/base/Makefile.in,v  <--  Makefile.in
new revision: 1.24; previous revision: 1.23
done
Checking in base/nsEmbedAPI.cpp;
/cvsroot/mozilla/embedding/base/nsEmbedAPI.cpp,v  <--  nsEmbedAPI.cpp
new revision: 1.41; previous revision: 1.40
done
Checking in browser/activex/src/control/Makefile.in;
/cvsroot/mozilla/embedding/browser/activex/src/control/Makefile.in,v  <-- 
Makefile.in
new revision: 1.16; previous revision: 1.15
done
Checking in browser/gtk/tests/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.21; previous revision: 1.20
done
Checking in browser/gtk/tests/TestGtkEmbed.cpp;
/cvsroot/mozilla/embedding/browser/gtk/tests/TestGtkEmbed.cpp,v  <-- 
TestGtkEmbed.cpp
new revision: 1.31; previous revision: 1.30
done
Checking in tests/mfcembed/Makefile.in;
/cvsroot/mozilla/embedding/tests/mfcembed/Makefile.in,v  <--  Makefile.in
new revision: 1.17; previous revision: 1.16
done
Checking in tests/mfcembed/MfcEmbed.cpp;
/cvsroot/mozilla/embedding/tests/mfcembed/MfcEmbed.cpp,v  <--  MfcEmbed.cpp
new revision: 1.34; previous revision: 1.33
done
Checking in tests/mfcembed/MfcEmbed.h;
/cvsroot/mozilla/embedding/tests/mfcembed/MfcEmbed.h,v  <--  MfcEmbed.h
new revision: 1.18; previous revision: 1.17
done
Checking in tests/mfcembed/ProfilesDlg.cpp;
/cvsroot/mozilla/embedding/tests/mfcembed/ProfilesDlg.cpp,v  <--  ProfilesDlg.cpp
new revision: 1.8; previous revision: 1.7
done
Checking in tests/mfcembed/winEmbedFileLocProvider.cpp;
/cvsroot/mozilla/embedding/tests/mfcembed/winEmbedFileLocProvider.cpp,v  <-- 
winEmbedFileLocProvider.cpp
new revision: 1.15; previous revision: 1.14
done
Checking in tests/mfcembed/components/nsPrintDialogUtil.cpp;
/cvsroot/mozilla/embedding/tests/mfcembed/components/nsPrintDialogUtil.cpp,v 
<--  nsPrintDialogUtil.cpp
new revision: 1.4; previous revision: 1.3
done
Checking in tests/winEmbed/Makefile.in;
/cvsroot/mozilla/embedding/tests/winEmbed/Makefile.in,v  <--  Makefile.in
new revision: 1.9; previous revision: 1.8
done
Checking in winEmbedFileLocProvider.cpp;
/cvsroot/mozilla/embedding/tests/mfcembed/winEmbedFileLocProvider.cpp,v  <-- 
winEmbedFileLocProvider.cpp
new revision: 1.16; previous revision: 1.15
done

Comment 8

[Philip K. Warren]

This patch broke the AIX tinderbox. I will attach a quick fix for this problem
to this bug.

Comment 9

[Philip K. Warren]

Attachment: Fix for AIX

Comment 10

[Doug Turner (:dougt)]

Checking in Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/src/Makefile.in,v  <--  Makefile.in
new revision: 1.36; previous revision: 1.35
done

Got it!  thanks.

Comment 11

[Doug Turner (:dougt)]

backed out - caused GRE regression.

Comment 12

[Doug Turner (:dougt)]

mass reassigning to nobody.

Comment 13

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.