Closed Bug 1575999 Opened 2 years ago Closed 11 months ago

Android javadoc lint isn't sufficiently strict

Categories

(GeckoView :: General, enhancement, P3)

Unspecified
All
enhancement

Tracking

(firefox70 wontfix, firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox70 --- wontfix
firefox79 --- fixed

People

(Reporter: nalexander, Assigned: agi)

References

(Blocks 1 open bug, Regression)

Details

Attachments

(1 file)

Locally, I observe:

 2:07.37     public void setWebNotificationDelegate(final @Nullable WebNotificationDelegate delegate) {
 2:07.37                 ^
 2:07.58 1 warning

How did that sneak past the new Javadoc lint? The answer is that it’s an “up-to-date” thing. The way that Gradle works, it doesn’t actually re-run the Javadoc task, so the warning doesn’t show up if it's shown up in a previous task (build, say). That's what's happening, I think, in the A(lints) job where this landed: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2d59ce318c46327d78c46c00086ea847223c383c&selectedJob=262768326.

To address this, I reckon that we need to do one of the following, in rough descending order of preference:

  1. Ensure that the JSON output file is a task output, and ensure that it's not in the objdir before we run the lint, so that the task must run to create it
  2. Split the Gradle tasks in some way so that Javadoc always runs
  3. Force the Javadoc task to always run (and accept slower local builds)
Type: defect → enhancement
Priority: -- → P2
Rank: 40
Rank: 40 → 19
Priority: P2 → P3
Assignee: nobody → agi
Status: NEW → ASSIGNED
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f5a98fe7608
Always run javadoc tasks during lint. r=nalexander,esawin
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.